-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
errors, readline: migrate to use internal/errors.js #11390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
slammayjammay
wants to merge
7
commits into
nodejs:master
from
slammayjammay:internal-errors-readline
Closed
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3bb5126
errors, readline: migrate to use internal/errors.js
slammayjammay 035094c
errors, readline: integrate changes from master
slammayjammay 7cf13a0
errors: readline: throw more accurate errors
slammayjammay 88b663f
errors, readline: revert accidental whitespace change
slammayjammay 9c6045f
errors, readline: avoid contraction in error message
slammayjammay c238fb9
errors, readline: fix lint error
slammayjammay 4041b97
errors, readline: pass tests
slammayjammay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
errors, readline: revert accidental whitespace change
- Loading branch information
commit 88b663fc32ab80912adffe2aa7a77c88a103ee5c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidental whitespace change?