Skip to content

Upgrade to nan 1.7.0 #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orderedlist merged 2 commits into from
Mar 1, 2015
Merged

Upgrade to nan 1.7.0 #446

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c03d634
Upgrade to nan 1.7.0
orderedlist Mar 1, 2015
c73435e
Explicit typecast of the callback to uv_async_cb
orderedlist Mar 1, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Explicit typecast of the callback to uv_async_cb
  • Loading branch information
@orderedlist
orderedlist committed Mar 1, 2015
commit c73435eefc929a2123669d1da3f668cfd01d7231
4 changes: 2 additions & 2 deletions generate/templates/partials/callback_helpers.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
baton->req.data = baton;
baton->done = false;

uv_async_init(uv_default_loop(), &baton->req, {{ cppFunctionName }}_{{ cbFunction.name }}_async);
uv_async_init(uv_default_loop(), &baton->req, (uv_async_cb) {{ cppFunctionName }}_{{ cbFunction.name }}_async);
uv_async_send(&baton->req);

while(!baton->done) {
Expand Down Expand Up @@ -80,7 +80,7 @@ void {{ cppClassName }}::{{ cppFunctionName }}_{{ cbFunction.name }}_async(uv_as

NanAssignPersistent(baton->promise, promise);

uv_async_init(uv_default_loop(), &baton->req, {{ cppFunctionName }}_{{ cbFunction.name }}_asyncPromisePolling);
uv_async_init(uv_default_loop(), &baton->req, (uv_async_cb) {{ cppFunctionName }}_{{ cbFunction.name }}_asyncPromisePolling);
uv_async_send(&baton->req);
return;
}
Expand Down
4 changes: 2 additions & 2 deletions generate/templates/partials/field_accessors.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
baton->req.data = baton;
baton->done = false;

uv_async_init(uv_default_loop(), &baton->req, {{ field.name }}_async);
uv_async_init(uv_default_loop(), &baton->req, (uv_async_cb) {{ field.name }}_async);
uv_async_send(&baton->req);

while(!baton->done) {
Expand Down Expand Up @@ -173,7 +173,7 @@

NanAssignPersistent(baton->promise, promise);

uv_async_init(uv_default_loop(), &baton->req, {{ field.name }}_asyncPromisePolling);
uv_async_init(uv_default_loop(), &baton->req, (uv_async_cb) {{ field.name }}_asyncPromisePolling);
uv_async_send(&baton->req);
return;
}
Expand Down