Skip to content

Upgrade to nan 1.7.0#446

Merged
orderedlist merged 2 commits intomasterfrom
ol-upgrade-nan
Mar 1, 2015
Merged

Upgrade to nan 1.7.0#446
orderedlist merged 2 commits intomasterfrom
ol-upgrade-nan

Conversation

@orderedlist
Copy link
Copy Markdown
Collaborator

Hopefully this'll fix the apm install issues.

@johnhaley81
Copy link
Copy Markdown
Collaborator

We'll need to add atom shell and nwjs into our test matrix.

On Sun, Mar 1, 2015, 1:23 PM Steve Smith notifications@github.com wrote:

Hopefully this'll fix the apm install issues.

You can view, comment on, or merge this pull request online at:

#446
Commit Summary

  • Upgrade to nan 1.7.0

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#446.

@orderedlist
Copy link
Copy Markdown
Collaborator Author

Yeah, I still can't get apm install to work pointing to this sha. 😢

@orderedlist
Copy link
Copy Markdown
Collaborator Author

apm install worked with that last commit.

@orderedlist
Copy link
Copy Markdown
Collaborator Author

yes

orderedlist added a commit that referenced this pull request Mar 1, 2015
@orderedlist orderedlist merged commit f0b29f5 into master Mar 1, 2015
@orderedlist orderedlist deleted the ol-upgrade-nan branch March 1, 2015 22:12
@johnhaley81
Copy link
Copy Markdown
Collaborator

👍

On Sun, Mar 1, 2015, 3:12 PM Steve Smith notifications@github.com wrote:

Merged #446 #446.


Reply to this email directly or view it on GitHub
#446 (comment).

@johnhaley81 johnhaley81 added this to the 0.3.0 milestone Mar 2, 2015
@tbranyen tbranyen modified the milestone: 0.3.0 Mar 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants