Skip to content

This re-applies Gábor's stream closing work with some additional fixes #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snorp wants to merge 6 commits into from
Closed

This re-applies Gábor's stream closing work with some additional fixes #84

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9d4279e
Proxy the 'listening' event from the underlying server
snorp Jul 16, 2014
a147f2f
Un-revert the close stream work that was reverted in node-http2-protocol
snorp Aug 26, 2014
82cdba5
Revert "Revert "HTTP - forwarding error and close events from streams…
snorp Aug 26, 2014
8ae50db
Add tests for response closing when the socket goes away
snorp Aug 28, 2014
74232ec
Don't try to write into closed streams
snorp Aug 28, 2014
48d2ea4
Fix 'close' event behavior
snorp Aug 28, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests for response closing when the socket goes away
  • Loading branch information
@snorp
snorp committed Aug 28, 2014
commit 8ae50db8ab495899460405068b6830f90d85d402
48 changes: 48 additions & 0 deletions test/http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,5 +434,53 @@ describe('http.js', function() {
});
});
});
describe('closing client connection socket', function() {
it('should close streams on server', function(done) {
var server = http2.createServer(options, function(request, response) {
request.once('error', util.noop);
response.once('error', util.noop);
response.once('close', done);

response.writeHead(200);
});

var agent = new http2.Agent();
server.listen(1243, function() {
http2.get({
scheme: 'https:',
host: 'localhost',
port: 1243,
path: '/foo',
agent: agent
}, function(response) {
response.once('error', util.noop);
agent.endpoints['false:localhost:1243'].socket.destroy();
}).once('error', util.noop);
});
});
it('should close streams on client', function(done) {
var server = http2.createServer(options, function(request, response) {
request.once('error', util.noop);
response.once('error', util.noop);

response.writeHead(200);
});

var agent = new http2.Agent();
server.listen(1244, function() {
http2.get({
scheme: 'https:',
host: 'localhost',
port: 1244,
path: '/foo',
agent: agent
}, function(response) {
response.once('close', done);
response.once('error', util.noop);
agent.endpoints['false:localhost:1244'].socket.destroy();
}).once('error', util.noop);
});
});
});
});
});