This re-applies Gábor's stream closing work with some additional fixes#84
This re-applies Gábor's stream closing work with some additional fixes#84snorp wants to merge 6 commits into
Conversation
This reverts a03dff630a33771d045ac0362023afb84b441aa4 from node-http2-protocol
… to req and res objects"" This reverts commit 5252939.
|
This still isn't correct wrt to the 'close' event in messages. That should only be emitted when the stream closes unexpectedly. Right now I think it fires any time the stream ends. |
|
Also, not sure what's up with the 0.11 failures. I don't have that installed here, so I'll try to do that and look into it. |
This fixes things so we emit 'close' only when it's an unexpected thing. Otherwise 'end' or 'finish' indicates normal termination. See http://nodejs.org/api/http.html#http_event_close_1 as well as http://nodejs.org/api/http.html#http_event_close_2
|
Thanks, I'll try to take care of the 0.11 fixes. There are subtle differences in the Stream class implementation which may cause trouble. Also, the definition of the "close" event is ambigous as it means different things on different kind of streams. It does not always mean unexpected close (sorry for not providing references to the documentation, but it should be easy to find the different definitions of the close event). For now, I merged this as close-stream-3 branch to not break CI, and will develop it there. |
No description provided.