Skip to content

Forward listening and error events. #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nwgh merged 1 commit into from
Jan 8, 2016
Merged

Forward listening and error events. #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions lib/http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,36 @@ exports.IncomingRequest = IncomingRequest;
exports.OutgoingResponse = OutgoingResponse;
exports.ServerResponse = OutgoingResponse; // for API compatibility

// Forward events `event` on `source` to all listeners on `target`.
//
// Note: The calling context is `source`.
function forwardEvent(event, source, target) {
function forward() {
var listeners = target.listeners(event);

var n = listeners.length;

// Special case for `error` event with no listeners.
if (n === 0 && event === 'error') {
var args = [event];
args.push.apply(args, arguments);

target.emit.apply(target, args);
return;
}

for (var i = 0; i < n; ++i) {
listeners[i].apply(source, arguments);
}
}

source.on(event, forward);

// A reference to the function is necessary to be able to stop
// forwarding.
return forward;
}

// Server class
// ------------

Expand Down Expand Up @@ -430,6 +460,9 @@ function Server(options) {
}
});
this._server.on('request', this.emit.bind(this, 'request'));

forwardEvent('error', this._server, this);
forwardEvent('listening', this._server, this);
}

// HTTP2 over plain TCP
Expand Down
30 changes: 30 additions & 0 deletions test/http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,36 @@ describe('http.js', function() {
}).to.throw(Error);
});
});
describe('method `listen()`', function () {
it('should emit `listening` event', function (done) {
var server = http2.createServer(serverOptions);

server.on('listening', function () {
server.close();

done();
})

server.listen(0);
});
it('should emit `error` on failure', function (done) {
var server = http2.createServer(serverOptions);

// This TCP server is used to explicitly take a port to make
// server.listen() fails.
var net = require('net').createServer();

server.on('error', function () {
net.close()

done();
});

net.listen(0, function () {
server.listen(this.address().port);
});
});
});
describe('property `timeout`', function() {
it('should be a proxy for the backing HTTPS server\'s `timeout` property', function() {
var server = new http2.Server(serverOptions);
Expand Down