Forward listening and error events.#153
Merged
Merged
Conversation
|
I opened up a similar issue (#155) as well, there already is some event forwarding code which likely needs to be refactored. |
Closed
nwgh
added a commit
that referenced
this pull request
Jan 8, 2016
Forward `listening` and `error` events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
listeningevent is currently not forwarded which force the user to pass a callback to.listen().This breaks certain patterns such as the use of event-to-promise.
The problem is worst for the
errorevent: because it is not forwarded, it will crash the process.