WIP 🐛 use map instead of filter to return a promise#842
Merged
MikhailArkhipov merged 1 commit intoFeb 21, 2018
Conversation
Author
|
Will add a test to test this. |
d991830 to
459a1c5
Compare
459a1c5 to
7841c03
Compare
Codecov Report
@@ Coverage Diff @@
## master #842 +/- ##
==========================================
- Coverage 63.46% 63.45% -0.01%
==========================================
Files 258 258
Lines 11845 11843 -2
Branches 2104 2104
==========================================
- Hits 7517 7515 -2
Misses 4320 4320
Partials 8 8
Continue to review full report at Codecov.
|
MikhailArkhipov
approved these changes
Feb 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug introduced in #831
Selection of interpreters throws error. Not creating an issue for this, just tying it to the original issue that #831 resolved.
Using
mapto ensure a promise is returned.