Improve virtual env detection + #807#831
Merged
Merged
Conversation
added 27 commits
February 16, 2018 10:50
DonJayamanne
approved these changes
Feb 20, 2018
| const env = results.find(items => items.result === true); | ||
| return env ? env.env : undefined; | ||
| }); | ||
| public async detect(pythonPath: string): Promise<string> { |
There was a problem hiding this comment.
Shouldn't this function return a boolean (the string returned implies a boolean)
Author
There was a problem hiding this comment.
I used to return identifier which was pair of name and the interpreter type. Not it is just name. Perhaps we should rename this to getEnvironmentName
Codecov Report
@@ Coverage Diff @@
## master #831 +/- ##
==========================================
- Coverage 63.76% 63.46% -0.31%
==========================================
Files 260 258 -2
Lines 11864 11845 -19
Branches 2103 2104 +1
==========================================
- Hits 7565 7517 -48
- Misses 4291 4320 +29
Partials 8 8
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #807
detectfrom provider since we detect ve universally at the manager lever