Skip to content

Fix multiroot workspace tests caused by logging PR#6443

Merged
kimadeline merged 4 commits into
microsoft:masterfrom
kimadeline:fix-multiroot-tests-logging
Jul 3, 2019
Merged

Fix multiroot workspace tests caused by logging PR#6443
kimadeline merged 4 commits into
microsoft:masterfrom
kimadeline:fix-multiroot-tests-logging

Conversation

@kimadeline

@kimadeline kimadeline commented Jul 3, 2019

Copy link
Copy Markdown

For #6442
Caused by the logging PR #6311

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [n/a] Has a news entry file (remember to thank yourself!)
  • [n/a] Appropriate comments and documentation strings in the code
  • [n/a] Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

@kimadeline kimadeline added the no-changelog No news entry required label Jul 3, 2019
@kimadeline kimadeline added no-changelog No news entry required and removed no-changelog No news entry required labels Jul 3, 2019
@kimadeline kimadeline merged commit 3695395 into microsoft:master Jul 3, 2019
@kimadeline kimadeline deleted the fix-multiroot-tests-logging branch July 3, 2019 23:06
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants