Skip to content

Add logging throughout the extension#6311

Merged
kimadeline merged 21 commits into
microsoft:masterfrom
kimadeline:1131-logging
Jul 3, 2019
Merged

Add logging throughout the extension#6311
kimadeline merged 21 commits into
microsoft:masterfrom
kimadeline:1131-logging

Conversation

@kimadeline

@kimadeline kimadeline commented Jun 24, 2019

Copy link
Copy Markdown

For #1131

Set up logging for all commands being executed on the user's behalf. The logging is in a separate ProcessLogger class which implements the IProcessLogger interface. Logging is triggered by events emitted by processes.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • [n/a] Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

Comment thread src/client/common/process/proc.ts Outdated
Comment thread src/client/common/process/proc.ts Outdated
Comment thread src/client/common/process/logger.ts Outdated
Comment thread src/client/common/process/types.ts Outdated
@kimadeline kimadeline marked this pull request as ready for review June 25, 2019 18:48
@kimadeline kimadeline changed the title WIP - Add logging throughout the extension Add logging throughout the extension Jun 25, 2019
@kimadeline kimadeline requested a review from DonJayamanne June 25, 2019 21:03
Comment thread src/client/common/process/types.ts Outdated
Comment thread package.nls.json Outdated
Comment thread src/client/common/process/logger.ts
Comment thread src/client/common/process/logger.ts Outdated
Comment thread src/client/common/process/processFactory.ts Outdated
Comment thread news/3 Code Health/1131.md Outdated
@kimadeline kimadeline requested a review from DonJayamanne June 26, 2019 19:04
Comment thread src/client/common/process/logger.ts Outdated
@kimadeline kimadeline requested a review from DonJayamanne July 2, 2019 21:01
@kimadeline kimadeline mentioned this pull request Jul 2, 2019
3 tasks
@kimadeline kimadeline merged commit 07a280c into microsoft:master Jul 3, 2019
@kimadeline kimadeline deleted the 1131-logging branch July 3, 2019 16:31
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants