Skip to content

Add dev flag to poetry installer #5495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karrtikr merged 3 commits into from
May 9, 2019
Merged

Add dev flag to poetry installer #5495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bbf74b
poetry dev
Yanpas Apr 26, 2019
b9c11cc
add news
Yanpas Apr 26, 2019
3725e80
Update news entry
DonJayamanne Apr 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions news/2 Fixes/5496.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Add dev flag to poetry installer.
(thanks [Yan Pashkovsky](https://github.com/Yanpas))
2 changes: 1 addition & 1 deletion src/client/common/installer/poetryInstaller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export class PoetryInstaller extends ModuleInstaller implements IModuleInstaller
protected async getExecutionInfo(moduleName: string, resource?: Uri): Promise<ExecutionInfo> {
const execPath = this.configurationService.getSettings(resource).poetryPath;
return {
args: ['add', moduleName],
args: ['add', '--dev', moduleName],
execPath
};
}
Expand Down
2 changes: 1 addition & 1 deletion src/test/common/installer/poetryInstaller.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,6 @@ suite('Module Installer - Poetry', () => {

const info = await poetryInstaller.getExecutionInfo('something', uri);

assert.deepEqual(info, { args: ['add', 'something'], execPath: 'poetry path' });
assert.deepEqual(info, { args: ['add', '--dev', 'something'], execPath: 'poetry path' });
});
});