Skip to content

Add dev flag to poetry installer#5495

Merged
karrtikr merged 3 commits into
microsoft:masterfrom
Yanpas:fix_poetry
May 9, 2019
Merged

Add dev flag to poetry installer#5495
karrtikr merged 3 commits into
microsoft:masterfrom
Yanpas:fix_poetry

Conversation

@Yanpas
Copy link
Copy Markdown

@Yanpas Yanpas commented Apr 26, 2019 •
edited
Loading

For #5496

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

By default new dependencies like yapf, autopep8 are installed to all dependencies, --dev installs them to tool.poetry.dev-dependencies

@msftclas
Copy link
Copy Markdown

msftclas commented Apr 26, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@emmatyping
Copy link
Copy Markdown

emmatyping commented May 9, 2019

Just ran into this today. Would love to see it merged so it will make into 2019.5. Thank you for an awesome extension!

@karrtikr karrtikr merged commit 4614cca into microsoft:master May 9, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Yanpas @msftclas @emmatyping @DonJayamanne @karrtikr