Skip to content

Nightly build uses the unified step template#4838

Merged
d3r3kk merged 1 commit into
microsoft:masterfrom
d3r3kk:4806_nightly_ci_uses_unified_step
Mar 20, 2019
Merged

Nightly build uses the unified step template#4838
d3r3kk merged 1 commit into
microsoft:masterfrom
d3r3kk:4806_nightly_ci_uses_unified_step

Conversation

@d3r3kk
Copy link
Copy Markdown

@d3r3kk d3r3kk commented Mar 19, 2019

For #4806

  • All builds will now use the unified step template
  • Nightly runs
    • All OS variants, multiplied by:
    • All Python versions supported, multiplied by:
    • All tests
  • smokeTest has an incoming change before it will be run
  • Windows tests regularly fail with a false negative
  • Corrected bug with CI build (3.6 tests actually were running 3.7)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

For microsoft#4806

- All builds will now use the unified step template
- Nightly runs
  - All OS variants, multiplied by:
  - All Python versions supported, multiplied by:
  - All tests
- smokeTest has an incoming change before it will be run
- Windows tests regularly fail with  a false negative
- Corrected bug with CI build (3.6 tests actually were running 3.7)

---
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2019

Codecov Report

Merging #4838 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4838   +/-   ##
======================================
  Coverage      62%     62%           
======================================
  Files         373     373           
  Lines       14667   14667           
  Branches     1162    1162           
======================================
  Hits         9070    9070           
  Misses       5395    5395           
  Partials      202     202

@d3r3kk d3r3kk added the no-changelog No news entry required label Mar 19, 2019
@d3r3kk d3r3kk closed this Mar 19, 2019
@d3r3kk d3r3kk reopened this Mar 19, 2019
@d3r3kk d3r3kk merged commit faefc70 into microsoft:master Mar 20, 2019
@d3r3kk d3r3kk deleted the 4806_nightly_ci_uses_unified_step branch March 20, 2019 00:45
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant