Skip to content

Corrected Smoke test failure for 'Run Python File In Terminal' #4809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karrtikr merged 8 commits into from
Mar 20, 2019
Merged

Corrected Smoke test failure for 'Run Python File In Terminal' #4809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f202ad5
Correct Smoke test failure for 'Run Python File In Terminal'
Mar 18, 2019
7c4c656
news entry
Mar 18, 2019
801bde6
Run smoke tests on CI
Mar 18, 2019
a7672d4
Catch errors and continue execution
Mar 18, 2019
98f2fba
correct CI
Mar 18, 2019
b2ddc09
Corrected build number and install
Mar 19, 2019
dcdab21
CI
Mar 19, 2019
900b93c
Code review
Mar 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions build/ci/templates/test_phases.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,9 +413,10 @@ steps:
# > npm run package
# > npx gulp clean:cleanExceptTests
# > npm run testSmoke
- script: |
- bash: |
npm install -g vsce
npm run clean
npm run updateBuildNumber -- --buildNumber $TRAVIS_BUILD_NUMBER
npm run updateBuildNumber -- --buildNumber $BUILD_BUILDID
npm run package
npx gulp clean:cleanExceptTests
npm run testSmoke
Expand Down
4 changes: 2 additions & 2 deletions build/ci/vscode-python-pr-validation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
'Mac-Py3.7 Unit+Single':
PythonVersion: '3.7'
VMImageName: 'macos-10.13'
TestsToRun: 'testUnitTests, pythonUnitTests, testSingleWorkspace'
TestsToRun: 'testUnitTests, pythonUnitTests, testSingleWorkspace, testSmoke'
NeedsPythonTestReqs: true
'Mac-Py2.7 Unit+Single':
PythonVersion: '2.7'
Expand All @@ -60,7 +60,7 @@ jobs:
'Linux-Py3.7 Unit+Single':
PythonVersion: '3.7'
VMImageName: 'ubuntu-16.04'
TestsToRun: 'testUnitTests, pythonUnitTests, testSingleWorkspace'
TestsToRun: 'testUnitTests, pythonUnitTests, testSingleWorkspace, testSmoke'
NeedsPythonTestReqs: true
'Linux-Py2.7 Unit+Single':
PythonVersion: '2.7'
Expand Down
1 change: 1 addition & 0 deletions news/3 Code Health/4515.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Corrected Smoke test failure for 'Run Python File In Terminal'
2 changes: 1 addition & 1 deletion src/test/smoke/runInTerminal.smoke.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ suite('Smoke Test: Run Python File In Terminal', () => {
}
const textDocument = await openFile(file);

await vscode.commands.executeCommand<void>('python.execInTerminal', textDocument.uri, outputFile);
await vscode.commands.executeCommand<void>('python.execInTerminal', textDocument.uri);
const checkIfFileHasBeenCreated = () => fs.pathExists(outputFile);
await waitForCondition(checkIfFileHasBeenCreated, 30_000, `"${outputFile}" file not created`);
});
Expand Down
13 changes: 8 additions & 5 deletions src/testMultiRootWkspc/smokeTests/testExecInTerminal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,14 @@
import os

optlist, args = getopt.getopt(sys.argv, '')
if len(args) < 2:
help_msg = '{} requires 1 parameter - the full path specification of the logfile to write.'.format(args[0])
raise RuntimeError(help_msg)

log_file = args[1]

# If the caller has not specified the output file, create one for them with
# the same name as the caller script, but with a .log extension.
log_file = os.path.splitext(sys.argv[0])[0] + '.log'

# If the output file is given, use that instead.
if len(args) == 2:
log_file = args[1]

with open(log_file, "a") as f:
f.write(sys.executable)