Skip to content

Corrected Smoke test failure for 'Run Python File In Terminal'#4809

Merged
karrtikr merged 8 commits into
microsoft:masterfrom
karrtikr:correctsmoketest
Mar 20, 2019
Merged

Corrected Smoke test failure for 'Run Python File In Terminal'#4809
karrtikr merged 8 commits into
microsoft:masterfrom
karrtikr:correctsmoketest

Conversation

@karrtikr
Copy link
Copy Markdown

@karrtikr karrtikr commented Mar 18, 2019

For #4515

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2019

Codecov Report

Merging #4809 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4809   +/-   ##
======================================
  Coverage      62%     62%           
======================================
  Files         373     373           
  Lines       14667   14667           
  Branches     1162    1162           
======================================
  Hits         9070    9070           
  Misses       5395    5395           
  Partials      202     202

@karrtikr karrtikr closed this Mar 18, 2019
@karrtikr karrtikr reopened this Mar 18, 2019
@karrtikr karrtikr closed this Mar 18, 2019
@karrtikr karrtikr reopened this Mar 18, 2019
Comment thread src/test/smokeTest.ts Outdated
@karrtikr karrtikr requested review from DonJayamanne and removed request for DonJayamanne March 19, 2019 00:10
Comment thread src/test/smokeTest.ts Outdated
@karrtikr karrtikr merged commit 17f9647 into microsoft:master Mar 20, 2019
@karrtikr karrtikr deleted the correctsmoketest branch March 20, 2019 06:24
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants