Changes to logic for selection of best (default) version of Python interpreter#3813
Merged
Merged
Conversation
9e6975a to
2bc224e
Compare
* master: Added system tests to check activation for virtual environments (#3592)
7ea2c32 to
3b56b15
Compare
* master: Improvements to message displayed when linter is not installed (#3798)
d3r3kk
suggested changes
Jan 2, 2019
|
Overall I like the change. There will have to be some back and forth on what constitutes the 'best interpreter' but I think you've largely nailed it for the majority of our users. I like the approach you took with the rule evaluator, I think that will make it very simple/flexible to sort out issues or change priority of 'best interpreters' found on a system. |
rchiodo
reviewed
Jan 3, 2019
d3r3kk
reviewed
Jan 3, 2019
|
Still a few comments. |
d3r3kk
approved these changes
Jan 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #3369
Depends on #3809
Depends on #3812
Add tests for
configSettings.tsby injectingIWorkspaceService.This must be done as Multi Root (functional) tests failed.
We need to add unit tests to cover it.
Add tests (Would be nice to see convertPythonVersionToSemver get some unit test attention. Otherwise, this PR looks great. I do appreciate the large amount of work it took to replace this functionality with SemVer!)
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)