Refactor how version information is stored against interpreter information#3812
Merged
Conversation
40831f0 to
8e70e2b
Compare
8 tasks
* refactorAvailability: Fix broken tests
d3r3kk
approved these changes
Dec 27, 2018
d3r3kk
left a comment
There was a problem hiding this comment.
Would be nice to see convertPythonVersionToSemver get some unit test attention. Otherwise, this PR looks great. I do appreciate the large amount of work it took to replace this functionality with SemVer!
(Again, pending testing-success is assumed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #3369
After #3809
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)