Skip to content

Remove MPLS support from the extension #17835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karthiknadig merged 9 commits into from
Oct 25, 2021
Merged

Remove MPLS support from the extension #17835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4c4e6a5
Remove MPLS support from the extension
karthiknadig Oct 21, 2021
9ba1429
Remove MPLS settings and migrate some settings
karthiknadig Oct 22, 2021
502109e
Fix for tests
karthiknadig Oct 22, 2021
0091b86
Remove more settings
karthiknadig Oct 22, 2021
c3ac50b
Address review comments.
karthiknadig Oct 22, 2021
acc3909
Cleanup .eslintignore
karthiknadig Oct 22, 2021
bcddf08
Move updating settings to diagnostics
karthiknadig Oct 25, 2021
4d99b95
Implement no-op for python._loadLanguageServerExtension
karthiknadig Oct 25, 2021
f94a0d8
Add tests for switch to LS diagnostic
karthiknadig Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 0 additions & 53 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,10 @@ src/test/unittests.ts
src/test/vscode-mock.ts

src/test/interpreters/mocks.ts
src/test/interpreters/interpreterVersion.unit.test.ts
src/test/interpreters/virtualEnvs/index.unit.test.ts
src/test/interpreters/virtualEnvs/condaInheritEnvPrompt.unit.test.ts
src/test/interpreters/virtualEnvManager.unit.test.ts
src/test/interpreters/pythonPathUpdaterFactory.unit.test.ts
src/test/interpreters/activation/service.unit.test.ts
src/test/interpreters/helpers.unit.test.ts
src/test/interpreters/currentPathService.unit.test.ts
src/test/interpreters/display.unit.test.ts

src/test/terminals/codeExecution/terminalCodeExec.unit.test.ts
Expand All @@ -46,16 +42,6 @@ src/test/providers/codeActionProvider/main.unit.test.ts
src/test/providers/shebangCodeLenseProvider.unit.test.ts

src/test/activation/activationService.unit.test.ts
src/test/activation/languageServer/downloadChannelRules.unit.test.ts
src/test/activation/languageServer/languageServer.unit.test.ts
src/test/activation/languageServer/languageServerFolderService.unit.test.ts
src/test/activation/languageServer/languageServerPackageRepository.unit.test.ts
src/test/activation/languageServer/manager.unit.test.ts
src/test/activation/languageServer/analysisOptions.unit.test.ts
src/test/activation/languageServer/languageServerExtension.unit.test.ts
src/test/activation/languageServer/languageClientFactory.unit.test.ts
src/test/activation/languageServer/outputChannel.unit.test.ts
src/test/activation/languageServer/languageServerPackageService.unit.test.ts
src/test/activation/activeResource.unit.test.ts
src/test/activation/node/languageServerChangeHandler.unit.test.ts
src/test/activation/node/activator.unit.test.ts
Expand All @@ -77,7 +63,6 @@ src/test/testing/common/debugLauncher.unit.test.ts
src/test/testing/common/services/configSettingService.unit.test.ts

src/test/common/exitCIAfterTestReporter.ts
src/test/common/crypto.unit.test.ts
src/test/common/net/fileDownloader.unit.test.ts
src/test/common/net/httpClient.unit.test.ts
src/test/common/terminals/activator/index.unit.test.ts
Expand Down Expand Up @@ -106,7 +91,6 @@ src/test/common/configSettings/configSettings.unit.test.ts
src/test/common/serviceRegistry.unit.test.ts
src/test/common/extensions.unit.test.ts
src/test/common/variables/envVarsService.unit.test.ts
src/test/common/nuget/azureBobStoreRepository.unit.test.ts
src/test/common/helpers.test.ts
src/test/common/application/commands/reloadCommand.unit.test.ts
src/test/common/installer/channelManager.unit.test.ts
Expand All @@ -121,12 +105,10 @@ src/test/common/process/processFactory.unit.test.ts
src/test/common/process/pythonToolService.unit.test.ts
src/test/common/process/proc.observable.test.ts
src/test/common/process/pythonProc.simple.multiroot.test.ts
src/test/common/process/execFactory.test.ts
src/test/common/process/logger.unit.test.ts
src/test/common/process/proc.exec.test.ts
src/test/common/process/pythonProcess.unit.test.ts
src/test/common/process/proc.unit.test.ts
src/test/common/asyncDump.ts
src/test/common/interpreterPathService.unit.test.ts
src/test/common/insidersBuild/insidersExtensionPrompt.unit.test.ts
src/test/common/insidersBuild/downloadChannelService.unit.test.ts
Expand Down Expand Up @@ -163,13 +145,10 @@ src/test/telemetry/envFileTelemetry.unit.test.ts

src/test/linters/pylint.unit.test.ts
src/test/linters/lint.unit.test.ts
src/test/linters/linter.availability.unit.test.ts
src/test/linters/common.ts
src/test/linters/lintengine.test.ts
src/test/linters/lint.multilinter.test.ts
src/test/linters/lint.test.ts
src/test/linters/linterinfo.unit.test.ts
src/test/linters/lint.manager.unit.test.ts
src/test/linters/linterCommands.unit.test.ts
src/test/linters/linterManager.unit.test.ts

Expand All @@ -182,7 +161,6 @@ src/test/application/diagnostics/checks/updateTestSettings.unit.test.ts
src/test/application/diagnostics/checks/powerShellActivation.unit.test.ts
src/test/application/diagnostics/checks/invalidPythonPathInDebugger.unit.test.ts
src/test/application/diagnostics/checks/envPathVariable.unit.test.ts
src/test/application/diagnostics/checks/lsNotSupported.unit.test.ts
src/test/application/diagnostics/applicationDiagnostics.unit.test.ts
src/test/application/diagnostics/promptHandler.unit.test.ts
src/test/application/diagnostics/sourceMapSupportService.unit.test.ts
Expand All @@ -200,8 +178,6 @@ src/client/interpreter/configuration/services/workspaceUpdaterService.ts
src/client/interpreter/configuration/services/workspaceFolderUpdaterService.ts
src/client/interpreter/helpers.ts
src/client/interpreter/virtualEnvs/condaInheritEnvPrompt.ts
src/client/interpreter/virtualEnvs/types.ts
src/client/interpreter/virtualEnvs/index.ts
src/client/interpreter/activation/service.ts
src/client/interpreter/display/shebangCodeLensProvider.ts
src/client/interpreter/display/index.ts
Expand All @@ -216,7 +192,6 @@ src/client/terminals/codeExecution/codeExecutionManager.ts
src/client/terminals/codeExecution/djangoContext.ts

src/client/providers/serviceRegistry.ts
src/client/providers/completionSource.ts
src/client/providers/formatProvider.ts
src/client/providers/importSortProvider.ts
src/client/providers/replProvider.ts
Expand All @@ -226,28 +201,12 @@ src/client/providers/codeActionProvider/pythonCodeActionProvider.ts
src/client/providers/linterProvider.ts
src/client/providers/terminalProvider.ts

src/client/activation/languageServer/manager.ts
src/client/activation/languageServer/languageServerExtension.ts
src/client/activation/languageServer/languageServerProxy.ts
src/client/activation/languageServer/languageClientFactory.ts
src/client/activation/languageServer/platformData.ts
src/client/activation/languageServer/languageServerCompatibilityService.ts
src/client/activation/languageServer/languageServerPackageRepository.ts
src/client/activation/languageServer/languageServerFolderService.ts
src/client/activation/languageServer/outputChannel.ts
src/client/activation/languageServer/languageServerPackageService.ts
src/client/activation/languageServer/analysisOptions.ts
src/client/activation/languageServer/activator.ts
src/client/activation/commands.ts
src/client/activation/progress.ts
src/client/activation/extensionSurvey.ts
src/client/activation/common/languageServerChangeHandler.ts
src/client/activation/common/activatorBase.ts
src/client/activation/common/languageServerFolderService.ts
src/client/activation/common/languageServerPackageService.ts
src/client/activation/common/packageRepository.ts
src/client/activation/common/analysisOptions.ts
src/client/activation/common/downloadChannelRules.ts
src/client/activation/refCountedLanguageServer.ts
src/client/activation/languageClientMiddleware.ts
src/client/activation/node/manager.ts
Expand Down Expand Up @@ -328,21 +287,11 @@ src/client/common/utils/misc.ts
src/client/common/utils/cacheUtils.ts
src/client/common/utils/workerPool.ts
src/client/common/extensions.ts
src/client/common/dotnet/compatibilityService.ts
src/client/common/dotnet/serviceRegistry.ts
src/client/common/dotnet/services/unknownOsCompatibilityService.ts
src/client/common/dotnet/services/macCompatibilityService.ts
src/client/common/dotnet/services/linuxCompatibilityService.ts
src/client/common/dotnet/services/windowsCompatibilityService.ts
src/client/common/logger.ts
src/client/common/variables/serviceRegistry.ts
src/client/common/variables/environment.ts
src/client/common/variables/types.ts
src/client/common/variables/systemVariables.ts
src/client/common/nuget/azureBlobStoreNugetRepository.ts
src/client/common/nuget/nugetRepository.ts
src/client/common/nuget/types.ts
src/client/common/nuget/nugetService.ts
src/client/common/cancellation.ts
src/client/common/interpreterPathService.ts
src/client/common/application/applicationShell.ts
Expand Down Expand Up @@ -419,7 +368,6 @@ src/client/debugger/extension/helpers/protocolParser.ts

src/client/linters/pydocstyle.ts
src/client/linters/serviceRegistry.ts
src/client/linters/linterAvailability.ts
src/client/linters/lintingEngine.ts
src/client/linters/prospector.ts
src/client/linters/linterInfo.ts
Expand All @@ -444,4 +392,3 @@ src/client/application/diagnostics/commands/ignore.ts
src/client/application/diagnostics/commands/factory.ts
src/client/application/diagnostics/commands/execVSCCommand.ts
src/client/application/diagnostics/commands/launchBrowser.ts

4 changes: 1 addition & 3 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"**/node_modules": true,
".vscode-test": false,
".vscode test": false,
"**/.mypy_cache/**": true,
"**/.mypy_cache/**": true
},
"search.exclude": {
"out": true, // set this to false to include "out" folder in search results
Expand Down Expand Up @@ -54,8 +54,6 @@
"source.fixAll.eslint": true
},
"python.languageServer": "Pylance",
"python.analysis.logLevel": "Trace",
"python.analysis.downloadChannel": "beta",
"python.linting.pylintEnabled": false,
"python.linting.flake8Enabled": true,
"cucumberautocomplete.skipDocStringsFormat": true,
Expand Down
1 change: 1 addition & 0 deletions news/3 Code Health/17834.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove Microsoft Python Language Server support from the extension.
118 changes: 0 additions & 118 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,11 +286,6 @@
}
],
"commands": [
{
"category": "Python",
"command": "python.analysis.clearCache",
"title": "%python.command.python.analysis.clearCache.title%"
},
{
"category": "Python",
"command": "python.analysis.restartLanguageServer",
Expand Down Expand Up @@ -460,119 +455,12 @@
],
"configuration": {
"properties": {
"python.analysis.cacheFolderPath": {
"description": "Path to a writable folder where analyzer can cache its data. Change requires restart.",
"scope": "resource",
"type": "string"
},
"python.analysis.diagnosticPublishDelay": {
"default": 1000,
"description": "Delay before diagnostic messages are transferred to the problems list (in milliseconds).",
"scope": "resource",
"type": "integer"
},
"python.analysis.disabled": {
"default": [],
"description": "List of suppressed diagnostic messages.",
"items": {
"type": "string"
},
"scope": "resource",
"type": "array"
},
"python.analysis.errors": {
"default": [],
"description": "List of diagnostics messages to be shown as errors.",
"items": {
"type": "string"
},
"scope": "resource",
"type": "array"
},
"python.analysis.information": {
"default": [],
"description": "List of diagnostics messages to be shown as information.",
"items": {
"type": "string"
},
"scope": "resource",
"type": "array"
},
"python.analysis.logLevel": {
"default": "Error",
"description": "Defines type of log messages language server writes into the output window.",
"enum": [
"Error",
"Information",
"Trace",
"Warning"
],
"scope": "resource",
"type": "string"
},
"python.analysis.memory.keepLibraryAst": {
"default": false,
"description": "Allows code analysis to keep parser trees in memory. Increases memory consumption but may improve performance with large library analysis.",
"scope": "resource",
"type": "boolean"
},
"python.analysis.symbolsHierarchyDepthLimit": {
"default": 10,
"description": "Limits depth of the symbol tree in the document outline.",
"scope": "resource",
"type": "integer"
},
"python.analysis.typeshedPaths": {
"default": [],
"description": "Paths to Typeshed stub folders. Default is Typeshed installed with the language server. Change requires restart.",
"items": {
"type": "string"
},
"scope": "resource",
"type": "array"
},
"python.analysis.warnings": {
"default": [],
"description": "List of diagnostics messages to be shown as warnings.",
"items": {
"type": "string"
},
"scope": "resource",
"type": "array"
},
"python.autoComplete.addBrackets": {
"default": false,
"description": "Automatically add brackets for functions.",
"scope": "resource",
"type": "boolean"
},
"python.autoComplete.extraPaths": {
"default": [],
"description": "List of paths to libraries and the like that need to be imported by auto complete engine. E.g. when using Google App SDK, the paths are not in system path, hence need to be added into this list.",
"scope": "resource",
"type": "array"
},
"python.autoComplete.showAdvancedMembers": {
"default": true,
"description": "Controls appearance of methods with double underscores in the completion list.",
"scope": "resource",
"type": "boolean"
},
"python.autoComplete.typeshedPaths": {
"default": [],
"description": "Specifies paths to local typeshed repository clone(s) for the Python language server.",
"items": {
"type": "string"
},
"scope": "resource",
"type": "array"
},
"python.autoUpdateLanguageServer": {
"default": true,
"description": "Automatically update the language server.",
"scope": "application",
"type": "boolean"
},
"python.condaPath": {
"default": "",
"description": "Path to the conda executable to use for activation (version 4.4+).",
Expand Down Expand Up @@ -1705,12 +1593,6 @@
],
"menus": {
"commandPalette": [
{
"category": "Python",
"command": "python.analysis.clearCache",
"title": "%python.command.python.analysis.clearCache.title%",
"when": "!virtualWorkspace && shellExecutionSupported"
},
{
"category": "Python",
"command": "python.analysis.restartLanguageServer",
Expand Down
8 changes: 2 additions & 6 deletions package.nls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
"python.command.python.runLinting.title": "Run Linting",
"python.command.python.enableSourceMapSupport.title": "Enable Source Map Support For Extension Debugging",
"python.command.python.clearPersistentStorage.title": "Clear Internal Extension Cache",
"python.command.python.analysis.clearCache.title": "Clear Module Analysis Cache",
"python.command.python.analysis.restartLanguageServer.title": "Restart Language Server",
"python.command.python.launchTensorBoard.title": "Launch TensorBoard",
"python.command.python.refreshTensorBoard.title": "Refresh TensorBoard",
Expand Down Expand Up @@ -166,7 +165,7 @@
"Testing.configureTests": "Configure Test Framework",
"Testing.testNotConfigured": "No test framework configured.",
"Common.openOutputPanel": "Show output",
"LanguageService.statusItem.name":"Python IntelliSense Status",
"LanguageService.statusItem.name": "Python IntelliSense Status",
"LanguageService.statusItem.text": "Partial Mode",
"LanguageService.statusItem.detail": "Limited IntelliSense provided by Pylance",
"LanguageService.lsFailedToStart": "We encountered an issue starting the language server. Reverting to Jedi language engine. Check the Python output panel for details.",
Expand All @@ -177,7 +176,6 @@
"LanguageService.extractionCompletedOutputMessage": "Language server download complete",
"LanguageService.extractionDoneOutputMessage": "done",
"LanguageService.reloadVSCodeIfSeachPathHasChanged": "Search paths have changed for this Python interpreter. Please reload the extension to ensure that the IntelliSense works correctly",
"LanguageService.startingMicrosoft": "Starting Microsoft Python language server.",
"LanguageService.startingPylance": "Starting Pylance language server.",
"LanguageService.startingJedi": "Starting Jedi language server.",
"LanguageService.startingNone": "Editor support is inactive since language server is set to None.",
Expand Down Expand Up @@ -220,7 +218,5 @@
"TensorBoard.launchNativeTensorBoardSessionCodeLens": "▶ Launch TensorBoard Session",
"TensorBoard.enterRemoteUrl": "Enter remote URL",
"TensorBoard.enterRemoteUrlDetail": "Enter a URL pointing to a remote directory containing your TensorBoard log files",
"MPLSDeprecation.bannerMessage": "The Microsoft Python Language Server is reaching end of life at the beginning of November. If you do not select a new language server, you will have your setting automatically updated at deprecation. Read more about this in our [September release blog post](https://aka.ms/pvsc-september-2021). Please switch your language server to a supported value:",
"MPLSDeprecation.switchToPylance": "Switch to Pylance (recommended)",
"MPLSDeprecation.switchToJedi": "Switch to Jedi (open source)"
"SwitchToDefaultLS.bannerMessage": "The Microsoft Python Language Server has reached end of life. Your language server has been set to the default for Python in VS Code, Pylance. If you’d like to change your language server, you can learn about how to do so [here](https://devblogs.microsoft.com/python/python-in-visual-studio-code-may-2021-release/#configuring-your-language-server). Read Pylance’s license [here](https://marketplace.visualstudio.com/items/ms-python.vscode-pylance/license)."
Comment thread
karthiknadig marked this conversation as resolved.
}
2 changes: 0 additions & 2 deletions package.nls.zh-cn.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
"python.command.python.runLinting.title": "执行代码检查",
"python.command.python.enableSourceMapSupport.title": "为扩展调试启用 Source Map 支持",
"python.command.python.clearPersistentStorage.title": "清空扩展内部缓存",
"python.command.python.analysis.clearCache.title": "清除模块分析缓存",
"python.command.python.analysis.restartLanguageServer.title": "重启语言服务器",
"python.command.python.launchTensorBoard.title": "启动 TensorBoard",
"python.command.python.refreshTensorBoard.title": "刷新 TensorBoard",
Expand Down Expand Up @@ -169,7 +168,6 @@
"LanguageService.extractionCompletedOutputMessage": "语言服务器下载完成",
"LanguageService.extractionDoneOutputMessage": "完成",
"LanguageService.reloadVSCodeIfSeachPathHasChanged": "该 Python 解释器的搜索路径已改变，请重新加载扩展以确保 IntelliSense 正常工作。",
"LanguageService.startingMicrosoft": "正在启动 Microsoft Python 语言服务器。",
"LanguageService.startingPylance": "正在启动 Pylance 语言服务器。",
"LanguageService.startingJedi": "正在启动 Jedi Python 语言服务器。",
"LanguageService.startingNone": "由于语言服务器设置为空，编辑器支持处于非活动状态。",
Expand Down
Loading