Remove MPLS support from the extension#17835
Merged
Merged
Conversation
jakebailey
reviewed
Oct 21, 2021
jakebailey
reviewed
Oct 21, 2021
ed6dcb5 to
4c4e6a5
Compare
Member
Author
|
@kimadeline @karrtikr Added you to this just as a FYI. Since we are removing several settings. |
kimadeline
approved these changes
Oct 22, 2021
karrtikr
previously requested changes
Oct 22, 2021
karrtikr
left a comment
There was a problem hiding this comment.
I do not see any tests for the switch to default LS prompt, also it's better to implement it as a diagnostic unless I'm missing something. LGTM otherwise.
Member
Author
|
I will be moving this to Diagnostic and adding tests in a separate PR. |
I will be moving this to Diagnostic and adding tests in a separate PR.
Closed
Member
Author
|
Moved to diagnostics in this change itself, added test for the diagnostics. |
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
* Remove MPLS support from the extension * Remove MPLS settings and migrate some settings * Fix for tests * Remove more settings * Address review comments. * Cleanup .eslintignore * Move updating settings to diagnostics * Implement no-op for python._loadLanguageServerExtension * Add tests for switch to LS diagnostic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17834