Fix go to definition in Python notebooks (#16385)#16448
Conversation
* notebook renamed to notebooks, notebooks symbols moved to workspace namespace * Drop usage of NotebookCellMetadata ctor
|
@karrtikr was thinking I'd just update the CHANGELOG directly, but I can also do the news entry and then your team can put that into the CHANGELOG in a separate PR? Whichever y'all prefer |
…ow.activeNotebookEditor` (#16381) * vscode.window.activeNotebookEditor * window.visibleNotebookEditors
|
Oh I didn't notice this is the release branch. It's fine to edit the changelog then. |
IanMatthewHuff
left a comment
There was a problem hiding this comment.
Looks good. Tested on 1.57 stable?
|
@IanMatthewHuff yes:
The build I have is from a CI run on this PR (number is different than any of the ones that have been published to marketplace):
|
|
There's a venv test failure on this PR, I'm trying to identify whether it's related to these changes or also a problem on the main branch. |
|
The test failure (Windows venv) is also present on main. @karthiknadig can this PR be merged? |
|
Merged per conversation with Karthik on Teams. |
Point fix for language server support in the Python extension in VS Code Stable 1.57.0. This fix was submitted to main but needed to be included in a hotfix release.