Update tests: vscode.notebook.activeNotebookEditor --> vscode.window.activeNotebookEditor#16381
Merged
Conversation
| return true; | ||
| } | ||
| return !!(vscode as any).notebook.activeNotebookEditor; | ||
| return !!(vscode as any).window.activeNotebookEditor; |
Member
There was a problem hiding this comment.
There is another .notebook just above this one that also needs changing.
IanMatthewHuff
requested changes
Jun 3, 2021
Member
IanMatthewHuff
left a comment
There was a problem hiding this comment.
Just one more .notebook instance needed. I put a comment in.
DavidKutu
approved these changes
Jun 3, 2021
9 tasks
Author
|
Go to definition failure is legit. Will open a separate PR to fix that. |
IanMatthewHuff
approved these changes
Jun 3, 2021
joyceerhl
added a commit
that referenced
this pull request
Jun 10, 2021
* Fix go to definition in Python notebooks (#16385) * notebook renamed to notebooks, notebooks symbols moved to workspace namespace * Drop usage of NotebookCellMetadata ctor * Update tests: `vscode.notebook.activeNotebookEditor` --> `vscode.window.activeNotebookEditor` (#16381) * vscode.window.activeNotebookEditor * window.visibleNotebookEditors * Remove deprecated `NotebookCellData` constructor parameter (#16390) * Update smoke tests and add CHANGELOG item
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For microsoft/vscode-jupyter#6101