Ensure experiment framework can be created using standard utils#15150
Merged
Conversation
ericsnowcurrently
approved these changes
Jan 14, 2021
ericsnowcurrently
left a comment
There was a problem hiding this comment.
LGTM
I've left a few comments but none are critical.
Codecov Report
@@ Coverage Diff @@
## main #15150 +/- ##
======================================
- Coverage 65% 65% -1%
======================================
Files 561 561
Lines 26523 26525 +2
Branches 3800 3803 +3
======================================
- Hits 17272 17271 -1
- Misses 8551 8552 +1
- Partials 700 702 +2
|
kimadeline
approved these changes
Jan 14, 2021
b3d75ae to
cab899d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier experiment framework was dependent on config service, which was dependent on autoselection, which was dependent on all of legacy discovery code. This code changes experiment framework to use workspace service instead, which has no dependencies.
I have verified that I'm able to fetch experiment framework using service container just before we register legacy discovery classes.