Use PythonInterpreterLocatorService and other classes only when in experiment#15152
Merged
Conversation
added 4 commits
January 14, 2021 16:00
Codecov Report
@@ Coverage Diff @@
## main #15152 +/- ##
======================================
- Coverage 65% 65% -1%
======================================
Files 561 561
Lines 26525 26540 +15
Branches 3803 3806 +3
======================================
+ Hits 17271 17277 +6
- Misses 8552 8560 +8
- Partials 702 703 +1
|
karthiknadig
requested changes
Jan 15, 2021
karthiknadig
approved these changes
Jan 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
registerLegacyDiscoveryForIOCis now an async function, I had to propogateasyncall the way up everywhere.