Skip to content

Update package.json #14430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joyceerhl merged 1 commit into from
Oct 29, 2020
Merged

Update package.json #14430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions build/ci/templates/steps/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ steps:
displayName: 'Update release Version of Extension'
condition: and(succeeded(), startsWith(variables['Build.SourceBranchName'], 'release'))

- bash: |
npm run addExtensionDependencies
displayName: 'Add extension dependencies to package.json'

- bash: |
npm run package
displayName: 'Build VSIX'
Expand Down
13 changes: 13 additions & 0 deletions gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,19 @@ gulp.task('webpack', async () => {
await buildWebPackForDevOrProduction('./build/webpack/webpack.extension.config.js', 'extension');
});

gulp.task('addExtensionDependencies', async () => {
await addExtensionDependencies();
});

async function addExtensionDependencies() {
// Update the package.json to add extension dependencies at build time so that
// extension dependencies need not be installed during development
const packageJsonContents = await fsExtra.readFile('package.json', 'utf-8');
const packageJson = JSON.parse(packageJsonContents);
packageJson.extensionDependencies = ["ms-toolsai.jupyter"].concat(packageJson.extensionDependencies ? packageJson.extensionDependencies : []);
await fsExtra.writeFile('package.json', JSON.stringify(packageJson, null, 4), 'utf-8');
}

gulp.task('updateBuildNumber', async () => {
await updateBuildNumber(argv);
});
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1963,6 +1963,7 @@
"lint": "tslint src/**/*.ts -t verbose",
"prettier-fix": "prettier 'src/**/*.ts*' --write && prettier 'build/**/*.js' --write",
"clean": "gulp clean",
"addExtensionDependencies": "gulp addExtensionDependencies",
"updateBuildNumber": "gulp updateBuildNumber",
"verifyBundle": "gulp verifyBundle",
"webpack": "webpack"
Expand Down