Update package.json#14430
Conversation
Codecov Report
@@ Coverage Diff @@
## main #14430 +/- ##
==========================================
- Coverage 65.01% 65.01% -0.01%
==========================================
Files 539 539
Lines 25050 25050
Branches 3533 3533
==========================================
- Hits 16287 16286 -1
- Misses 8102 8103 +1
Partials 661 661
Continue to review full report at Codecov.
|
rchiodo
left a comment
There was a problem hiding this comment.
Waiting on what Don said. We need to only put the dependency in the package.json during build time.
835bde5 to
9ad320f
Compare
IanMatthewHuff
left a comment
There was a problem hiding this comment.
Hey Joyce. Sorry about the pain on this. But this is looking to merge into WIP/NoDS. We need it going into that new myNoDS branch that is off of main. That branch has the correct commits to not have a bunch of merge conflicts going into main due to the squash merges into WIP/NoDS.
DonJayamanne
left a comment
There was a problem hiding this comment.
Something that was discussed with core team was to bring the smoke tests into Python repo (bring back old smoke tests):
- This way we know python extension works well with DS (rather than expecting DS to test integration with Python), so they know what they could be breaking in DS early on.
- You just need the
dataScienec.smoke.test.tsfiles from DS code.
DonJayamanne
left a comment
There was a problem hiding this comment.
You will also need to update the Github Actions (as they have smoke tests running in github actions too), else merging this PR into main will break CI.
2937b6a to
092bc6d
Compare
092bc6d to
576d7c3
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).