Skip to content

Port TemplateStringsArray immutability to release-2.0#9855

Merged
DanielRosenwasser merged 3 commits into
release-2.0from
tsaImmutableTo-2.0
Jul 21, 2016
Merged

Port TemplateStringsArray immutability to release-2.0#9855
DanielRosenwasser merged 3 commits into
release-2.0from
tsaImmutableTo-2.0

Conversation

@DanielRosenwasser
Copy link
Copy Markdown
Member

@DanielRosenwasser DanielRosenwasser commented Jul 21, 2016

Ports #9561 to release-2.0.

@DanielRosenwasser DanielRosenwasser merged commit 253253d into release-2.0 Jul 21, 2016
@DanielRosenwasser DanielRosenwasser deleted the tsaImmutableTo-2.0 branch July 21, 2016 21:37
@jkillian
Copy link
Copy Markdown

This forces all users to change any template string tag functions, correct?

For example, in TSLint we have:

export function dedent(strings: string[], ...values: string[]) {

which now needs to be changed to

export function dedent(strings: TemplateStringsArray, ...values: string[]) {

@jkillian
Copy link
Copy Markdown

jkillian commented Jul 26, 2016

On further examination, this is fine by me 👍
I had initially thought that TemplateStringsArray was a new type introduced for 2.0. But I see that it existed before, and I can (and should) use the same type with 1.8 compatible code.

jkillian pushed a commit to palantir/tslint that referenced this pull request Jul 26, 2016
This allows the code to compile correctly with TS 1.8.x and TS 2.x

See microsoft/TypeScript#9855 also
adidahiya pushed a commit to palantir/tslint that referenced this pull request Jul 27, 2016
This allows the code to compile correctly with TS 1.8.x and TS 2.x

See microsoft/TypeScript#9855 also
adidahiya pushed a commit to palantir/tslint that referenced this pull request Jul 27, 2016
This allows the code to compile correctly with TS 1.8.x and TS 2.x

See microsoft/TypeScript#9855 also
soniro pushed a commit to soniro/tslint that referenced this pull request Aug 31, 2016
This allows the code to compile correctly with TS 1.8.x and TS 2.x

See microsoft/TypeScript#9855 also
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants