Skip to content

Make TemplateStringsArray immutable.#9561

Merged
DanielRosenwasser merged 4 commits into
masterfrom
tsaImmutable
Jul 21, 2016
Merged

Make TemplateStringsArray immutable.#9561
DanielRosenwasser merged 4 commits into
masterfrom
tsaImmutable

Conversation

@DanielRosenwasser
Copy link
Copy Markdown
Member

Both the raw array as well as the cooked array are frozen according to https://tc39.github.io/ecma262/2016/index.html#sec-gettemplateobject

@DanielRosenwasser
Copy link
Copy Markdown
Member Author

I think this should also be ported to release-2.0.

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Jul 7, 2016

@DanielRosenwasser can you look at the failing tests.

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Jul 7, 2016

👍

@DanielRosenwasser DanielRosenwasser added the Breaking Change Would introduce errors in existing code label Jul 8, 2016
@DanielRosenwasser DanielRosenwasser merged commit 6e4dd75 into master Jul 21, 2016
@DanielRosenwasser DanielRosenwasser deleted the tsaImmutable branch July 21, 2016 05:20
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Breaking Change Would introduce errors in existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants