Normalize basepath in parseJsonConfigFileContent()#9138
Conversation
|
Hi @otbe, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
Do you mind adding a unit test to https://github.com/Microsoft/TypeScript/blob/master/tests/cases/unittests/tsconfigParsing.ts |
|
I would like to do so, but its a bit tricky. Explanation: use the wrong (non-normalized) path. I wil change my PR to fix the concrete bug, but I don't know how to test this, because there is no test for Btw: I know nothing about the WScript subsystem, so maybe this fix is only needed for the Node subsystem. |
|
Superseded by #12667 |
This PR fixes #9123 by normalizing the path with
normalizeSlashes().Im not sure if this enough, please review :)