Skip to content

Normalize 'basePath' in 'parseJsonConfigFileContent'#12667

Merged
mhegazy merged 1 commit into
microsoft:masterfrom
bb:patch-1
Dec 22, 2016
Merged

Normalize 'basePath' in 'parseJsonConfigFileContent'#12667
mhegazy merged 1 commit into
microsoft:masterfrom
bb:patch-1

Conversation

@bb
Copy link
Copy Markdown
Contributor

@bb bb commented Dec 5, 2016

@msftclas
Copy link
Copy Markdown

msftclas commented Dec 5, 2016

Hi @bb, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Dec 5, 2016

thanks for the PR. can you also add a unit test to https://github.com/Microsoft/TypeScript/blob/master/src/harness/unittests/tsconfigParsing.ts

@bb
Copy link
Copy Markdown
Contributor Author

bb commented Dec 5, 2016

Yeah, I'll give it a try.

Beginners question: What's the right way to call gulp runtests?

I tried gulp runtests --tests=src/harness/unittests/tsconfigParsing.ts and quite a few others, but the output is always something like 0 passing (57ms) even so I definitely created a failing testcase: assert.isTrue(false, "should fail")

Because it's "0 passing", I assume I chose the wrong format for the tests argument and no test runs at all.

@bb
Copy link
Copy Markdown
Contributor Author

bb commented Dec 5, 2016

Nevermind, gulp runtests --tests=parseConfigFileTextToJson it is :)
Was easy to see after the full test finally broke after ages of running.

@mhegazy mhegazy closed this Dec 22, 2016
@mhegazy mhegazy reopened this Dec 22, 2016
@msftclas
Copy link
Copy Markdown

Hi @bb, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@DanielRosenwasser DanielRosenwasser changed the title fixes #9123 Normalize 'basePath' in 'parseJsonConfigFileContent' Dec 22, 2016
@mhegazy mhegazy merged commit 94b10f8 into microsoft:master Dec 22, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants