Skip to content

Declaration emit should retain (instead of elide) unresolved computed names #58428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weswigham merged 8 commits into from
May 7, 2024
Merged

Declaration emit should retain (instead of elide) unresolved computed names #58428

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8d79534
Declaration emit should retain unresolved computed names instead of e…
weswigham May 3, 2024
869ef5a
Update Baselines and/or Applied Lint Fixes
typescript-bot May 3, 2024
19375ee
Invert check
weswigham May 3, 2024
328d7f0
Revise assert
weswigham May 3, 2024
49cc279
Update Baselines and/or Applied Lint Fixes
typescript-bot May 3, 2024
d59c665
Change giant.ts to have a resolvable [p] so declaration emit is not b…
weswigham May 4, 2024
02b65ac
Modify node builder to have the same unresolved computed name retaini…
weswigham May 4, 2024
a2d209e
Update Baselines and/or Applied Lint Fixes
typescript-bot May 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revise assert
  • Loading branch information
@weswigham
weswigham committed May 3, 2024
commit 328d7f0729ba08694f7ae2847fb14ab060fce03c
8 changes: 4 additions & 4 deletions src/compiler/transformers/declarations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1007,11 +1007,11 @@ export function transformDeclarations(context: TransformationContext) {
context.addDiagnostic(createDiagnosticForNode(input, Diagnostics.Computed_properties_must_be_number_or_string_literals_variables_or_dotted_expressions_with_isolatedDeclarations));
}
if (!isEntityNameExpression(input.name.expression)) {
// A.B.C that is not late bound - usually this means the expression did not resolve.
// Check the entity name, and copy the declaration, rather than elide it (there's
// probably a checker error in the input, but this is most likely the desired output).
return;
}
// A.B.C that is not late bound - usually this means the expression did not resolve.
// Check the entity name, and copy the declaration, rather than elide it (there's
// probably a checker error in the input, but this is most likely the desired output).
}
}

Expand Down Expand Up @@ -1783,7 +1783,7 @@ export function transformDeclarations(context: TransformationContext) {
getSymbolAccessibilityDiagnostic = createGetSymbolAccessibilityDiagnosticForNodeName(node);
}
errorNameNode = (node as NamedDeclaration).name;
Debug.assert(resolver.isLateBound(getParseTreeNode(node) as Declaration)); // Should only be called with dynamic names
Debug.assert(hasDynamicName(node as NamedDeclaration)); // Should only be called with dynamic names
const decl = node as NamedDeclaration as LateBoundDeclaration;
const entityName = decl.name.expression;
checkEntityNameVisibility(entityName, enclosingDeclaration);
Expand Down