Modify node builder to have the same unresolved computed name retaini…

…ng behavior
microsoft · weswigham · May 7, 2024 · May 3, 2024 · May 3, 2024 · May 3, 2024
commit 02b65ac096f520f2e6080e1dfdfaa8ac6165b264
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -8459,7 +8459,9 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                     );
                 }
                 if (isNamedDeclaration(node) && node.name.kind === SyntaxKind.ComputedPropertyName && !isLateBindableName(node.name)) {
-                    return undefined;
+                    if (!(context.flags & NodeBuilderFlags.AllowUnresolvedComputedNames && hasDynamicName(node) && isEntityNameExpression(node.name.expression) && checkComputedPropertyName(node.name).flags & TypeFlags.Any)) {
+                        return undefined;
+                    }
                 }
                 if (
                     (isFunctionLike(node) && !node.type)

diff --git a/src/compiler/transformers/declarations.ts b/src/compiler/transformers/declarations.ts
@@ -233,6 +233,7 @@ const declarationEmitNodeBuilderFlags = NodeBuilderFlags.MultilineObjectLiterals
     NodeBuilderFlags.UseTypeOfFunction |
     NodeBuilderFlags.UseStructuralFallback |
     NodeBuilderFlags.AllowEmptyTuple |
+    NodeBuilderFlags.AllowUnresolvedComputedNames |
     NodeBuilderFlags.GenerateNamesForShadowedTypeParams |
     NodeBuilderFlags.NoTruncation;
 

diff --git a/src/compiler/types.ts b/src/compiler/types.ts
@@ -5433,6 +5433,7 @@ export const enum NodeBuilderFlags {
     // Errors (cont.)
     AllowNodeModulesRelativePaths           = 1 << 26,
     /** @internal */ DoNotIncludeSymbolChain = 1 << 27,    // Skip looking up and printing an accessible symbol chain
+    /** @internal */ AllowUnresolvedComputedNames = 1 << 32,
 
     IgnoreErrors = AllowThisInObjectLiteral | AllowQualifiedNameInPlaceOfIdentifier | AllowAnonymousIdentifier | AllowEmptyUnionOrIntersection | AllowEmptyTuple | AllowEmptyIndexInfoType | AllowNodeModulesRelativePaths,
 

diff --git a/tests/baselines/reference/transpile/declarationTypeWithComputedName.d.ts b/tests/baselines/reference/transpile/declarationTypeWithComputedName.d.ts
@@ -4,10 +4,19 @@ import {Foo} from './a';
 export type Bar = {
   [Foo.A]: 1;
   [Foo.B]: 2;
-}
+}
+
+export const valBar = null as any as {
+    [Foo.A]: 1;
+    [Foo.B]: 2;
+};
 //// [declarationTypeWithComputedName.d.ts] ////
 import { Foo } from './a';
 export type Bar = {
     [Foo.A]: 1;
     [Foo.B]: 2;
 };
+export declare const valBar: {
+    [Foo.A]: 1;
+    [Foo.B]: 2;
+};
diff --git a/tests/cases/transpile/declarationTypeWithComputedName.ts b/tests/cases/transpile/declarationTypeWithComputedName.ts
@@ -5,4 +5,9 @@ import {Foo} from './a';
 export type Bar = {
   [Foo.A]: 1;
   [Foo.B]: 2;
-}
+}
+
+export const valBar = null as any as {
+    [Foo.A]: 1;
+    [Foo.B]: 2;
+};