Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
ef2e1d9
Add TReturn/TNext to Iterable et al
rbuckton Apr 18, 2024
1a64ac9
Fix assignability checks, update baselines
rbuckton Apr 18, 2024
7aa2281
Fix lint
rbuckton Apr 18, 2024
be600a8
Revert incorrect lint fix
rbuckton Apr 18, 2024
afbfa69
Merge branch 'main' into iterator-default-return
rbuckton Apr 18, 2024
8182bfc
Fix failing tests
rbuckton Apr 18, 2024
ad451d1
Elide type arguments that match defaults for inferred Iterable et al
rbuckton Apr 19, 2024
ec82647
Set TReturn default to 'any', provide explicit type arguments where n…
rbuckton Apr 19, 2024
5cb0e10
Fix broken fourslash test
rbuckton Apr 19, 2024
52ed319
Use intrinsic type for builtin iterator return, PR feedback
rbuckton May 6, 2024
bb513be
Use BuiltinIteratorReturn in es2020.bigint and es2022.intl
rbuckton May 7, 2024
2d58aa5
Use BuiltinIteratorReturn in es2020.string and es2020.symbol.wellknown
rbuckton May 7, 2024
0bfb236
Update baselines
rbuckton May 7, 2024
e98303f
Use new --strictBuiltinIteratorReturn flag
rbuckton May 17, 2024
3a59acb
Merge branch 'main' into iterator-default-return
rbuckton May 17, 2024
8578a4d
Update baselines
rbuckton May 17, 2024
51151ee
Change default for 'TNext' to 'any'
rbuckton May 17, 2024
595707d
Change inferred return type of generators to 'undefined'
rbuckton May 20, 2024
2a4edbc
Revert and use 'void' for BuiltinIteratorReturn
rbuckton May 21, 2024
7d32efc
Merge branch 'main' into iterator-default-return
rbuckton May 23, 2024
db12e2f
Merge branch 'main' into iterator-default-return
rbuckton Jun 25, 2024
fe2ff63
Split the difference, only use 'undefined' for built-ins
rbuckton Jun 25, 2024
63bc5fb
Add test and address self-build issue
rbuckton Jun 26, 2024
eece783
Merge branch 'main' into iterator-default-return
rbuckton Jul 17, 2024
a0d5046
Merge branch 'main' into iterator-default-return
rbuckton Jul 17, 2024
2a6af13
Merge branch 'main' into iterator-default-return
rbuckton Jul 17, 2024
46eba67
Add isolatedDeclarations test
rbuckton Jul 18, 2024
b8f04f6
Fix typo in comment
rbuckton Jul 18, 2024
1a3669a
Move initialization of 'typeParameterCount'
rbuckton Jul 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert incorrect lint fix
  • Loading branch information
rbuckton committed Apr 18, 2024
commit be600a8db7b24593bfb9b75ce4c204766e20e129
2 changes: 1 addition & 1 deletion src/compiler/commandLineParser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3639,7 +3639,7 @@ export function convertJsonOption(
convertJsonOption(opt.element, value, basePath, errors, propertyAssignment, valueExpression, sourceFile);
}
else if (!isString(opt.type)) {
return convertJsonOptionOfCustomType(opt, value as string, errors, valueExpression, sourceFile);
return convertJsonOptionOfCustomType(opt as CommandLineOptionOfCustomType, value as string, errors, valueExpression, sourceFile);
}
const validatedValue = validateJsonOptionValue(opt, value, errors, valueExpression, sourceFile);
return isNullOrUndefined(validatedValue) ? validatedValue : normalizeNonListOptionValue(opt, basePath, validatedValue);
Expand Down