Fix failing tests

microsoft · rbuckton · Jul 19, 2024 · Apr 18, 2024 · Apr 18, 2024 · Apr 18, 2024
commit 8182bfc3c44867ce35692fcf50cfe688a1aaacaa
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -37202,7 +37202,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
             }
 
             // The global Generator type doesn't exist, so report an error
-            resolver.getGlobalGeneratorType(/*reportErrors*/ true);
+            resolver.getGlobalIterableIteratorType(/*reportErrors*/ true);
             return emptyObjectType;
         }
 

diff --git a/tests/baselines/reference/emitArrowFunctionES6.types b/tests/baselines/reference/emitArrowFunctionES6.types
@@ -79,10 +79,10 @@ var p1 = ([a]) => { };
 >  : ^^^
 
 var p2 = ([...a]) => { };
->p2 : ([...a]: Iterable<any>) => void
->   : ^      ^^^^^^^^^^^^^^^^^^^^^^^^
->([...a]) => { } : ([...a]: Iterable<any>) => void
->                : ^      ^^^^^^^^^^^^^^^^^^^^^^^^
+>p2 : ([...a]: Iterable<any, void, undefined>) => void
+>   : ^      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+>([...a]) => { } : ([...a]: Iterable<any, void, undefined>) => void
+>                : ^      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 >a : any[]
 >  : ^^^^^
 

diff --git a/tests/baselines/reference/generatorReturnTypeFallback.3.errors.txt b/tests/baselines/reference/generatorReturnTypeFallback.3.errors.txt
diff --git a/tests/baselines/reference/generatorReturnTypeFallback.3.symbols b/tests/baselines/reference/generatorReturnTypeFallback.3.symbols
@@ -1,11 +1,9 @@
 //// [tests/cases/conformance/generators/generatorReturnTypeFallback.3.ts] ////
 
 === generatorReturnTypeFallback.3.ts ===
-// Do not allow generators to fallback to IterableIterator while in strictNullChecks mode if they need a type for the sent value.
-// NOTE: In non-strictNullChecks mode, `undefined` (the default sent value) is assignable to everything.
 function* f() {
 >f : Symbol(f, Decl(generatorReturnTypeFallback.3.ts, 0, 0))
 
     const x: string = yield 1;
->x : Symbol(x, Decl(generatorReturnTypeFallback.3.ts, 3, 9))
+>x : Symbol(x, Decl(generatorReturnTypeFallback.3.ts, 1, 9))
 }
diff --git a/tests/baselines/reference/generatorReturnTypeFallback.3.types b/tests/baselines/reference/generatorReturnTypeFallback.3.types
@@ -1,17 +1,14 @@
 //// [tests/cases/conformance/generators/generatorReturnTypeFallback.3.ts] ////
 
 === generatorReturnTypeFallback.3.ts ===
-// Do not allow generators to fallback to IterableIterator while in strictNullChecks mode if they need a type for the sent value.
-// NOTE: In non-strictNullChecks mode, `undefined` (the default sent value) is assignable to everything.
 function* f() {
->f : () => {}
->  : ^^^^^^^^
+>f : () => IterableIterator<number, void, string>
+>  : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
     const x: string = yield 1;
 >x : string
 >  : ^^^^^^
 >yield 1 : any
->        : ^^^
 >1 : 1
 >  : ^
 }
diff --git a/tests/baselines/reference/jsxChildrenWrongType.types b/tests/baselines/reference/jsxChildrenWrongType.types
@@ -11,8 +11,8 @@ Instantiation count: 1,000
 
 interface PropsType {
     children: [string, number?] | Iterable<boolean>;
->children : [string, number?] | Iterable<boolean>
->         : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+>children : [string, number?] | Iterable<boolean, void, undefined>
+>         : ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 }
 declare class Foo extends React.Component<PropsType, {}> {}
 >Foo : Foo

diff --git a/tests/baselines/reference/types.forAwait.es2018.2.errors.txt b/tests/baselines/reference/types.forAwait.es2018.2.errors.txt
@@ -31,10 +31,12 @@ types.forAwait.es2018.2.ts(16,15): error TS2488: Type 'AsyncIterable<number, voi
         for (const x of asyncIterable) {
                         ~~~~~~~~~~~~~
 !!! error TS2488: Type 'AsyncIterable<number, void, undefined>' must have a '[Symbol.iterator]()' method that returns an iterator.
+!!! related TS2773 types.forAwait.es2018.2.ts:14:21: Did you forget to use 'await'?
         }
         for (y of asyncIterable) {
                   ~~~~~~~~~~~~~
 !!! error TS2488: Type 'AsyncIterable<number, void, undefined>' must have a '[Symbol.iterator]()' method that returns an iterator.
+!!! related TS2773 types.forAwait.es2018.2.ts:16:15: Did you forget to use 'await'?
         }
     }
 
diff --git a/tests/cases/conformance/generators/generatorReturnTypeFallback.3.ts b/tests/cases/conformance/generators/generatorReturnTypeFallback.3.ts
@@ -3,8 +3,6 @@
 // @noemit: true
 // @strict: true
 
-// Do not allow generators to fallback to IterableIterator while in strictNullChecks mode if they need a type for the sent value.
-// NOTE: In non-strictNullChecks mode, `undefined` (the default sent value) is assignable to everything.
 function* f() {
     const x: string = yield 1;
 }