Add rich navigation indexing action#45431
Conversation
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
orta
left a comment
There was a problem hiding this comment.
I read some of the code around this, the rough gist is that this action will generate lsif results (aka pre-baked LSP results) for the TypeScript repo. These results are then uploaded into a third-party server (I guess it's 1st party though because MS owns it) that are used for a version of vscode which runs in the browser. Unlike codespaces vscode.dev does not come with a SSH-able VM to work inside, instead it makes API requests for those responses to this server for the results of editor actions like 'go to definition'.
Feels like a pretty good abstraction to me
|
@orta all correct. Another good link to LSIF is https://microsoft.github.io/language-server-protocol/overviews/lsif/overview/ and https://microsoft.github.io/language-server-protocol/specifications/lsif/0.5.0/specification/ |
.lsifrc.json
Outdated
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
Any way we could have this in a subdirectory to minimize top-level clutter?
There was a problem hiding this comment.
Yes, can be in a sub directory. What name would you suggest?
There was a problem hiding this comment.
Alternatively we can move it to the GitHub action source (e.g. .github/workflows)
There was a problem hiding this comment.
I think moving it to .github/workflows would be ideal, not sure whether others agree.
There was a problem hiding this comment.
Maybe .github/workflow-resources in case adding things into the workflows folder has its own issues.
There was a problem hiding this comment.
Add it to github/workflow-resources to not tamper with a folder owned by github.
|
Thank you! |
* Add rich navigation indexing action * Remove dbaeumer/richNav from indexed branches * Move lsifrc file to .github folder * Remove dbaeumer/richNav
This PR adds a GitHub action that indexes the repository for the main and release branches (as well as PRs) and stores the index in RichNav. This allows browsing the repository via vscode.dev with support for rich code navigation.