Skip to content

Revert "Disallow incremental with noEmit"#33883

Merged
sheetalkamat merged 1 commit into
masterfrom
revert-32887-incrementalNoEmit
Oct 10, 2019
Merged

Revert "Disallow incremental with noEmit"#33883
sheetalkamat merged 1 commit into
masterfrom
revert-32887-incrementalNoEmit

Conversation

@sheetalkamat
Copy link
Copy Markdown
Member

Reverts #32887
Fixes #33809

@amcasey
Copy link
Copy Markdown
Member

amcasey commented Oct 8, 2019

I agree that a revert should fix the problem, but it seems like a sensible error. Would it be better to have isIncrementalCompilation return false when listing files? (We can always revert now and do something fancier in 3.8.)

@sheetalkamat sheetalkamat merged commit 57d7edb into master Oct 10, 2019
@sheetalkamat sheetalkamat deleted the revert-32887-incrementalNoEmit branch October 10, 2019 20:08
@sheetalkamat
Copy link
Copy Markdown
Member Author

@typescript-bot cherry pick this to release-3.7

@weswigham
Copy link
Copy Markdown
Member

We shouldn't be cherry-picking anything to the 3-7 branch right now, no? Everything going into master is still 3.7 bound.

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow noEmit and composite together in 3.7

3 participants