Skip to content

Disallow incremental with noEmit#32887

Merged
sheetalkamat merged 1 commit into
masterfrom
incrementalNoEmit
Aug 14, 2019
Merged

Disallow incremental with noEmit#32887
sheetalkamat merged 1 commit into
masterfrom
incrementalNoEmit

Conversation

@sheetalkamat
Copy link
Copy Markdown
Member

Fixes #32882

Copy link
Copy Markdown
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense

@sheetalkamat sheetalkamat merged commit 2483803 into master Aug 14, 2019
@sheetalkamat sheetalkamat deleted the incrementalNoEmit branch August 14, 2019 17:06
@sheetalkamat
Copy link
Copy Markdown
Member Author

@DanielRosenwasser @RyanCavanaugh Do we want this in 3.6?

@RyanCavanaugh
Copy link
Copy Markdown
Member

I don't think it's worth it - it's hard to get yourself into this state and isn't a regression from 3.5

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Forbid simultaneous noEmit and incremental

3 participants