Take comments into account when tracking sourcemap spans#2880
Merged
Conversation
Contributor
|
👍 |
… to break dependency loop.
…tWithoutSourceMap
DanielRosenwasser
added a commit
that referenced
this pull request
Apr 24, 2015
Take comments into account when tracking sourcemap spans
|
This doesn't fix the issue. module Q {
function P() {
// Test this
var a = 1;
}
}Running tsc --sourceMap produces the following files var Q;
(function (Q) {
function P() {
// Test this
var a = 1;
}
})(Q || (Q = {}));
//# sourceMappingURL=a.js.mapa.js.map: Now open this HTML in FF or Chrome , and you can still put a breakpoint on the comment.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1980.
This is an alternative to PR #2014.
Rather than fixing up each use site to choose between how to emit, we create a common path that understands the sourcemap/comment ordering.
We now have 4 functions:
emit- emits a node with sourcemap info and comments if appropriateemitNodeWithoutSourceMap- emits a node with only comment infoemitVerbatimDeclarationName- emits a node with sourcemaps/comments without renaming if it is an identifieremitNodeWorker- emits a node with comments if appropriate, and takes a flag indicating whether or not to track sourcemaps. This is only called by the above two functions.