Fixes the interaction between sourcemaps and comments generation so that the source spans are emitted correctly#2014
Closed
sheetalkamat wants to merge 3 commits into
Closed
Fixes the interaction between sourcemaps and comments generation so that the source spans are emitted correctly#2014sheetalkamat wants to merge 3 commits into
sheetalkamat wants to merge 3 commits into
Conversation
Contributor
|
handled by #2880 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that emitNode is modified to emit comments, it resulted in unintentional incorrect behavior for emitting span of the node. When emitting comments and sourcemap we would like to start the record of the span only after emitting the comments otherwise it results in wrong span recording.