Avoid parameter initializer and update baselines

microsoft · Oct 23, 2018 · Oct 23, 2018 · Oct 23, 2018 · Oct 23, 2018 · f7df31949fa4487199d80bc1c6203a850dc2a524
commit f7df31949fa4487199d80bc1c6203a850dc2a524
diff --git a/src/services/types.ts b/src/services/types.ts
@@ -731,11 +731,11 @@ namespace ts {
         readonly indentMultiLineObjectLiteralBeginningOnBlankLine?: boolean;
     }
 
-    export function getDefaultFormatCodeSettings(newLineCharacter = "\n"): FormatCodeSettings {
+    export function getDefaultFormatCodeSettings(newLineCharacter?: string): FormatCodeSettings {
         return {
             indentSize: 4,
             tabSize: 4,
-            newLineCharacter,
+            newLineCharacter: newLineCharacter || "\n",
             convertTabsToSpaces: true,
             indentStyle: IndentStyle.Smart,
             insertSpaceAfterConstructor: false,

diff --git a/src/testRunner/unittests/tsserverProjectSystem.ts b/src/testRunner/unittests/tsserverProjectSystem.ts
@@ -6834,7 +6834,7 @@ namespace ts.projectSystem {
                             {
                                 start: { line: 0, offset: 0 },
                                 end: { line: 0, offset: 0 },
-                                newText: "export const a = 0;",
+                                newText: "export const a = 0;\n",
                             },
                         ],
                     }

diff --git a/tests/cases/fourslash/moveToNewFile.ts b/tests/cases/fourslash/moveToNewFile.ts
@@ -23,7 +23,8 @@ a; y;`,
         "/y.ts":
 `import { b } from './other';
 import { p } from './a';
-export const y: Date = p + b;`,
+export const y: Date = p + b;
+`,
     },
 
     preferences: {

diff --git a/tests/cases/fourslash/moveToNewFile_bindingPatterns.ts b/tests/cases/fourslash/moveToNewFile_bindingPatterns.ts
@@ -13,7 +13,8 @@ verify.moveToNewFile({
         "/a.ts": "",
 
         "/x.ts":
-`export const [x, { p: y }] = [0, { p: 1 }];`,
+`export const [x, { p: y }] = [0, { p: 1 }];
+`,
 
         "/b.ts":
 `

diff --git a/tests/cases/fourslash/moveToNewFile_declarationKinds.ts b/tests/cases/fourslash/moveToNewFile_declarationKinds.ts
@@ -33,6 +33,7 @@ export namespace N {
 }
 export type T = number;
 export interface I {
-}`,
+}
+`,
     },
 });
diff --git a/tests/cases/fourslash/moveToNewFile_defaultExport.ts b/tests/cases/fourslash/moveToNewFile_defaultExport.ts
@@ -16,7 +16,8 @@ verify.moveToNewFile({
 f();`,
 
         "/f.ts":
-`export default function f() { }`,
+`export default function f() { }
+`,
 
         "/user.ts":
 `import f from "./f";

diff --git a/tests/cases/fourslash/moveToNewFile_defaultImport.ts b/tests/cases/fourslash/moveToNewFile_defaultImport.ts
@@ -12,6 +12,7 @@ verify.moveToNewFile({
 
         "/x.ts":
 `import f from "./a";
-const x = f();`,
+const x = f();
+`,
     },
 });
diff --git a/tests/cases/fourslash/moveToNewFile_exportImport.ts b/tests/cases/fourslash/moveToNewFile_exportImport.ts
@@ -15,6 +15,7 @@ M;`,
 
         "/O.ts":
 `import { N } from "./a";
-export import O = N;`,
+export import O = N;
+`,
     },
 });
diff --git a/tests/cases/fourslash/moveToNewFile_format.ts b/tests/cases/fourslash/moveToNewFile_format.ts
@@ -16,6 +16,7 @@ verify.moveToNewFile({
         "/f.ts":
 `function f() {
 	const x = 0;
-}`,
+}
+`,
     },
 });
diff --git a/tests/cases/fourslash/moveToNewFile_getter.ts b/tests/cases/fourslash/moveToNewFile_getter.ts
@@ -23,7 +23,8 @@ verify.moveToNewFile({
 
         "/g.ts":
 `import { C } from "./a";
-export const { g, h: i } = new C();`,
+export const { g, h: i } = new C();
+`,
 
         "/b.ts":
 `

diff --git a/tests/cases/fourslash/moveToNewFile_global.ts b/tests/cases/fourslash/moveToNewFile_global.ts
@@ -11,6 +11,7 @@ verify.moveToNewFile({
 `,
 
         "/y.ts":
-`const y = x;`,
+`const y = x;
+`,
     },
 });
diff --git a/tests/cases/fourslash/moveToNewFile_importEquals.ts b/tests/cases/fourslash/moveToNewFile_importEquals.ts
@@ -13,6 +13,7 @@ verify.moveToNewFile({
 j;`,
         "/y.ts":
 `import i = require("./i");
-const y = i;`,
+const y = i;
+`,
     },
 });
diff --git a/tests/cases/fourslash/moveToNewFile_inferQuoteStyle.ts b/tests/cases/fourslash/moveToNewFile_inferQuoteStyle.ts
@@ -15,6 +15,7 @@ import { x } from './x';
 x;`,
 
         "/x.ts":
-`export const x = 0;`,
+`export const x = 0;
+`,
     },
 });
diff --git a/tests/cases/fourslash/moveToNewFile_js.ts b/tests/cases/fourslash/moveToNewFile_js.ts
@@ -30,6 +30,7 @@ const { p } = require("./a");
 const y = p + b;
 exports.y = y;
 const z = 0;
-exports.z = 0;`,
+exports.z = 0;
+`,
     },
 });
diff --git a/tests/cases/fourslash/moveToNewFile_jsx.ts b/tests/cases/fourslash/moveToNewFile_jsx.ts
@@ -9,6 +9,7 @@ verify.moveToNewFile({
 ``,
 
         "/newFile.tsx":
-`<div>a</div>;`,
+`<div>a</div>;
+`,
     }
 });
diff --git a/tests/cases/fourslash/moveToNewFile_moveImport.ts b/tests/cases/fourslash/moveToNewFile_moveImport.ts
@@ -14,6 +14,7 @@ b;`,
         "/l.ts":
 `import { a } from "m";
 let l;
-a;`,
+a;
+`,
     }
 });
diff --git a/tests/cases/fourslash/moveToNewFile_multiple.ts b/tests/cases/fourslash/moveToNewFile_multiple.ts
@@ -23,6 +23,7 @@ x; y;`,
 export const x = 0;
 a;
 export const y = 1;
-b;`,
+b;
+`,
     },
 });
diff --git a/tests/cases/fourslash/moveToNewFile_namespaceImport.ts b/tests/cases/fourslash/moveToNewFile_namespaceImport.ts
@@ -27,7 +27,8 @@ verify.moveToNewFile({
 `export const y = 0;`,
 
         "/x.ts":
-`export const x = 0;`,
+`export const x = 0;
+`,
 
         "/b.ts":
 `import * as a from "./a";

diff --git a/tests/cases/fourslash/moveToNewFile_newModuleNameUnique.ts b/tests/cases/fourslash/moveToNewFile_newModuleNameUnique.ts
@@ -15,6 +15,7 @@ verify.moveToNewFile({
 ``,
 
         "/x.2.ts":
-`export const x = 0;`,
+`export const x = 0;
+`,
     },
 });
diff --git a/tests/cases/fourslash/moveToNewFile_onlyStatements.ts b/tests/cases/fourslash/moveToNewFile_onlyStatements.ts
@@ -11,6 +11,7 @@ verify.moveToNewFile({
 `,
 
         "/newFile.ts":
-`console.log("goodbye");`,
+`console.log("goodbye");
+`,
     },
 });
diff --git a/tests/cases/fourslash/moveToNewFile_rangeSemiValid.ts b/tests/cases/fourslash/moveToNewFile_rangeSemiValid.ts
@@ -13,6 +13,7 @@ verify.moveToNewFile({
 const y = 0;`,
 
         "/x.ts":
-`const x = 0;`,
+`const x = 0;
+`,
     },
 });
diff --git a/tests/cases/fourslash/moveToNewFile_selectionOnName.ts b/tests/cases/fourslash/moveToNewFile_selectionOnName.ts
@@ -14,6 +14,7 @@ export {};
 export function gee() { eff(); }`,
         "/eff.ts":
 `import { gee } from "./a";
-export function eff() { gee(); }`,
+export function eff() { gee(); }
+`,
     },
 });
diff --git a/tests/cases/fourslash/moveToNewFile_tsconfig.ts b/tests/cases/fourslash/moveToNewFile_tsconfig.ts
@@ -18,7 +18,8 @@ verify.moveToNewFile({
 `,
 
         "/src/newFile.ts":
-`1;`,
+`1;
+`,
 
         "/src/tsconfig.json":
 `{

diff --git a/tests/cases/fourslash/moveToNewFile_updateUses.ts b/tests/cases/fourslash/moveToNewFile_updateUses.ts
@@ -17,7 +17,8 @@ verify.moveToNewFile({
 `,
 
         "/y.ts":
-`export const y = 0;`,
+`export const y = 0;
+`,
 
         "/user.ts":
 `import { x } from "./a";

diff --git a/tests/cases/fourslash/moveToNewFile_updateUses_js.ts b/tests/cases/fourslash/moveToNewFile_updateUses_js.ts
@@ -19,7 +19,8 @@ verify.moveToNewFile({
 `,
 
         "/y.js":
-`exports.y = 0;`,
+`exports.y = 0;
+`,
 
         "/user.js":
 // TODO: GH#22330

diff --git a/tests/cases/fourslash/moveToNewFile_variableDeclarationWithNoInitializer.ts b/tests/cases/fourslash/moveToNewFile_variableDeclarationWithNoInitializer.ts
@@ -14,6 +14,7 @@ export let x;
 
         "/y.ts":
 `import { x } from "./a";
-const y = x;`,
+const y = x;
+`,
     },
 });
-Original file line number
+Diff line change
@@ Expand Up / @@ -33,6 +33,7 @@ export namespace N { @@
     }
     export type T = number;
     export interface I {
-    }`,
+    }
+    `,
         },
     });