Skip to content

Add generateTypesForModule to public API#28069

Merged
2 commits merged intomasterfrom
generateTypesApi
Oct 23, 2018
Merged

Add generateTypesForModule to public API#28069
2 commits merged intomasterfrom
generateTypesApi

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 23, 2018

Make declaration-generating code public. Also makes the default format settings public so that this can be used easily.

Comment thread src/services/types.ts Outdated
readonly indentMultiLineObjectLiteralBeginningOnBlankLine?: boolean;
}

export function getDefaultFormatCodeSettings(newLineCharacter = "\n"): FormatCodeSettings {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using default value can you do this in literal at newLineCharacter || "\n"

@ghost ghost merged commit eadf44d into master Oct 23, 2018
@ghost ghost deleted the generateTypesApi branch October 23, 2018 23:10
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant