Add method signature handler to getTypeOfVariableOrParameterOrProperty#20825
Merged
weswigham merged 1 commit intoDec 29, 2017
Merged
Conversation
DanielRosenwasser
approved these changes
Dec 28, 2017
errendir
added a commit
to errendir/TypeScript
that referenced
this pull request
Jan 7, 2018
* origin/master: (216 commits) Accepted baselines. Check whether we have a class before testing whether we have a super-class. Added tests. LEGO: check in for master to temporary branch. LEGO: check in for master to temporary branch. Add method signature handler to getTypeOfVariableOrParameterOrProperty (microsoft#20825) LEGO: check in for master to temporary branch. Simplify test and add explanatory assertion LEGO: check in for master to temporary branch. Add dynamic file open test Allow dynamic files script info to be created when not opened by client LEGO: check in for master to temporary branch. Accept new baselines Add regression test Fix narrowTypeBySwitchOnDiscriminant function LEGO: check in for master to temporary branch. LEGO: check in for master to temporary branch. Move recursion limiter to individual resolve* functions User runner submodule improvements (microsoft#20868) Reset partial memberlist on defered circularity to calculate the correct members (microsoft#20179) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#20706 Made the declaration kinds handled by
getTypeOfVariableOrParameterOrPropertymore explicit, but didn't includeMethodSignature, which we have no normal tests covering. It being missing caused a DT test to trigger an assertion. There's a good chance this shouldn't be possible in the first place, but I need to open another issue to track that.