Ensure that we continue recursing into TS transforms#19650
Merged
mhegazy merged 2 commits intoNov 2, 2017
Conversation
…port elliding for transformed nodes, fix microsoft#19649
|
|
kriszyp
referenced
this pull request
Nov 1, 2017
* Failing test for missing transform output * dont elide all export stars * Remove comment from test * Refuse to perform ellision on transformed nodes
weswigham
approved these changes
Nov 1, 2017
Member
|
@kriszyp Hope you don't mind, I've pushed a more precise fix to your branch. |
Member
|
@mhegazy Could you add a review? |
Contributor
|
thanks! |
Contributor
Author
|
Any chance that this could be included in the next point release? (Our project doesn't compile at all without this). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that we continue recursing into TS transforms when avoiding export elliding for transformed nodes. This fixes #19649 .