Emit updated export declarations when transformed from export *#18017
Merged
Conversation
| }).outputText; | ||
|
|
||
| // Note: this is a simplified implementation that is missing some corner cases | ||
| // but is enough to show the bug. |
Member
There was a problem hiding this comment.
What bug? This comment has no reference to the original issue, so consider removing or adding details
|
What happens if we have an |
Member
Author
|
@Andy-MS I've changed how this is handled - now, rather than attempting to use the resolver with synthesized nodes (which is brittle, since we don't really support it), if a node which we perform ellision on is transformed, we no longer perform ellision on it. (This means anyone transforming these must perform any ellision themselves if they would want to do so.) |
mhegazy
approved these changes
Sep 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17597.