Fix instantiated generic mixin declaration emit#19144
Merged
Merged
Conversation
Member
Author
| context.encounteredError = true; | ||
| return undefined; | ||
| } | ||
| else if (context.flags & NodeBuilderFlags.WriteClassExpressionAsTypeLiteral && |
Member
There was a problem hiding this comment.
Where does this ever get passed in?
Member
Author
There was a problem hiding this comment.
Ahhhhh..... Nowhere (internally), apparently. Until the swap to the node builder in the other PR, we only use the symbol display builder to print classes as object literals.
Contributor
There was a problem hiding this comment.
So this should not be in this change? it should be in the symbolDisplayBuilder change instead...
mhegazy
approved these changes
Oct 13, 2017
Contributor
mhegazy
left a comment
There was a problem hiding this comment.
Please remove the WriteClassExpressionAsTypeLiteral from this PR and include it in the symbol display builder one.
mhegazy
added a commit
that referenced
this pull request
Oct 16, 2017
* unspoof call expression start in iife * add test * cleanup * rename variables * Use checkExpression to resolve symbols * Actual fix + test * revert method rename * explain changes and remove spurious assignment * add tests * verified that new tests show no regressions against master * remove newline * Refactor JSDoc types to Typescript types When the caret is on a Typescript declaration that has no type, but does have a JSDoc annotation with a type, this refactor will add the Typescript equivalent of the JSDoc type. Notes: 1. This doesn't delete the JSDoc comment or delete parts of it. In fact, due to bugs in trivia handling, it sometimes duplicates the comment. These bugs are tracked in #18626. 2. As a bonus, when `noImplicitAny: true`, this shows up as a code fix in VS Code whenever there is a no-implicit-any error. With `noImplicityAny: false`, this code must be invoked via the refactoring command. * Test:refactor JSDoc types to Typescript types * Change refactoring name and description * Move filenames to match refactoring rename * Transform jsdoc types in the refactor, not emitter The emitter now understands JSDoc types but emits them in the original format. * Correctly transform jsdoc parameter types And give a better name for rest params * Convert all JSDoc parameters and return types of functions * Add and update jsdoc annotation refactoring tests * Convert @template tag to type parameters in refactor * Test refactor of JSDoc @template tag * Fix duplicated JSDoc comments Incorporate suppressLeadingAndTrailingTrivia just added by @amcasey. * Create source files lazily in tests (#19143) * LEGO: check in for master to temporary branch. * JSDoc->type refactor:Renames+improve never handling * return more Debug.fails instead of undefined. * Fix spacing lint * In getContextuallyTypedParameterType, skip a `this` parameter when counting parameter index (#19155) * LEGO: check in for master to temporary branch. * Added test case. * Create truly unique names for tagged template strings. * Accepted baselines. * Update generated files (#19177) * Properly handle mapped types with 'keyof any' * LEGO: check in for master to temporary branch. * Mapped type { [P in any]: T } should yield { [x: string]: T } * Add tests * Accept new baselines * LEGO: check in for master to temporary branch. * Add getCompilerOptions method to project Fixes #19218 * In convertFunctionToEs6Class.ts, share code for getting symbol (#19160) * Fix for-in emit under systemjs (#19223) * Support 'package.json' not in package root (#19133) * Support 'package.json' not in package root * Test "foo/@bar" * More tests, and don't use "types" from the root package.json if not loading the root module * Add comments about why we need two methods that return compilerOptions * Fix instantiated generic mixin declaration emit (#19144) * Fix #18545, dont use declared type of class expression * Accept API Baselines * Add thus far unused flag from node builder * Accept baseline update * Do not reduce subtypes of awaited union type * Fix generated name scope when emitting async functions * LEGO: check in for master to temporary branch. * Add release-2.6 to covered branches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #19087, pulling the minimal amount in to fix this issue and identifying the secondary locations which needed fixing.
Fixes #18545