Skip to content

Fix instantiated generic mixin declaration emit#19087

Closed
weswigham wants to merge 59 commits into
microsoft:masterfrom
weswigham:fix-generic-mixin-emit
Closed

Fix instantiated generic mixin declaration emit#19087
weswigham wants to merge 59 commits into
microsoft:masterfrom
weswigham:fix-generic-mixin-emit

Conversation

@weswigham
Copy link
Copy Markdown
Member

@weswigham weswigham commented Oct 11, 2017

This is currently based on the PR removing the symbol writer, as I wanted to avoid needing to fix it in multiple places (as would be necessary to really fix it in the current version of the code), however I can rebase if need be.

Fixes #18545

@weswigham
Remove SymbolWriter, give methods to EmitTextWriter
bc8a27c
@weswigham
Unification of writers is done-ish
1dff649
@weswigham
Make node builder support more flags
7fa4ec9
@weswigham
Write out mixins like we used to
fc0ae76
@weswigham
Accept prototype-free baselines
72d413a
@weswigham
Use instantiated constraint when building mapped type nodes
e68c111
@weswigham
Accept better mapped type baselines
5645096
@weswigham
Report inaccessible this in node builder
9501e62
@weswigham
Turns out there was a bug in our codefix, too
1f5972a
@weswigham
Symbol display builder usage falling
266f553
@weswigham
Replace signatureToString with a nodeBuilder solution
b143516
@weswigham
Replace the last internal usages of the symbol writer
6c227b4
@weswigham
Accept semicolon additions
0e58719
@weswigham
Accept updated symbol baseline output
a926577
@weswigham
Start using node builder for some LS operations
d8dfe84
@weswigham
Remove those pesky trailing semicolons on signatures
d76ddef
@weswigham
Get signature printing much closer to old output
50cf103
@weswigham
Parameter lists should not be indented by default, especially when si…
a4725a8 
…ngle-line
@weswigham
Signatures up to snuff
ab99ee2
@weswigham
Type quickinfo emit is up to snuff
e28202a
@weswigham
Start of symbol writer replacement, needs a bit more for full compat
358c5c2
@weswigham
Slightly mor accurate to old behavior
4963b0f
@weswigham
Replicate qualified name type argument output correctly
581cf56
@weswigham
Bring back the old symbol baselines
5b90321
@weswigham
Mostly identical to old symbol emit now
83bea81
@weswigham
Perfectly matches old behavior thus far
8bb7230
@weswigham
Replace another usage of the symbol builder
cf6458f
@weswigham
Another usage removed
8a773ab
@weswigham
Another usage removed
1f5aec2
@weswigham
Remove final uses of symbol display builder
65a7a4b
weswigham added 21 commits October 2, 2017 12:55
@weswigham
writeList, not printList
9dba6f2
@weswigham
Remove listy writes and replace with new printer calls
06cd0be
@weswigham
Move ListFormat into types.ts
9f43e1c
@weswigham
Remove most new XToString functions in favor of node builder functions
cd3b058
@weswigham
Merge branch 'master' into couple-node-builder-with-symbol-tracker
03d7271
@weswigham
Merge branch 'master' into couple-node-builder-with-symbol-tracker
22c3f26
@weswigham
Accept API breaks
e5f99a1
@weswigham
Merge branch 'master' into couple-node-builder-with-symbol-tracker
ea3d727
@weswigham
Add getSymbolDisplayBuilder polyfill
af2734a
@weswigham
Accept updated API baseline
9a9652f
@weswigham
Move definition to make diff easier to read
d4b81e7
@weswigham
Reinternalize some things
48e3635
@weswigham
Remove trailign whitespace
5b75271
@weswigham
Reorder for zero diff
06d1a3e
@weswigham
Remove newline
9888084
@weswigham
Make shim mor eperfectly imitate old behavior
4db954e
@weswigham
Merge branch 'master' into couple-node-builder-with-symbol-tracker
6a1c51e
@weswigham
Merge branch 'master' into couple-node-builder-with-symbol-tracker
eb219a1
@weswigham
Merge branch 'master' into couple-node-builder-with-symbol-tracker
28edd45
@weswigham
Style feedback
2852452
@weswigham
Fix microsoft#18545, dont use declared type of class expression
0383ae2
@weswigham weswigham requested a review from mhegazy October 11, 2017 00:04
@weswigham weswigham changed the title Fix generic mixin emit Fix instnatiated generic mixin declaration emit Oct 11, 2017
@DanielRosenwasser DanielRosenwasser changed the title Fix instnatiated generic mixin declaration emit Fix instantiated generic mixin declaration emit Oct 12, 2017
@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Oct 12, 2017

If we can get the change without the symbol display builder changes so that we cna merge it in 2.6

the symbol display builder changes are 2.7 bound

@weswigham weswigham mentioned this pull request Oct 12, 2017
Merged
@weswigham
Copy link
Copy Markdown
Member Author

weswigham commented Oct 12, 2017

Superseded by #19144

@weswigham weswigham closed this Oct 12, 2017
@weswigham weswigham deleted the fix-generic-mixin-emit branch October 12, 2017 22:14
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mhegazy mhegazy Awaiting requested review from mhegazy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong declaration file for generic class factory

2 participants

@weswigham @mhegazy