Handle repeated substitution of the same symbol during extraction#18864
Merged
Conversation
RyanCavanaugh
approved these changes
Oct 2, 2017
mhegazy
approved these changes
Oct 2, 2017
Old: Insert the same Node for every occurrence. The position was repeatedly mutated during printing. New: Thunk the Node so that a new one is constructed for every occurrence. Fixes microsoft#18857
Member
Author
|
Latest push is just a rebase on top of #18861. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old: Insert the same Node for every occurrence. The position was
repeatedly mutated during printing.
New: Thunk the Node so that a new one is constructed for every
occurrence.
Fixes #18857
This is a solution, but it's not the only one. Deep cloning would also solve the problem (and might be cheaper).