Improve insertion positions of extracted constants#18861
Merged
Conversation
...mostly by putting them closer to the extraction site. They now also follow all leading comments in a file (unfortunately, including the doc comment on the first declaration). Bonus: Special case declaration lists - declare the new variable as part of the list, rather than before it, in case it depends on an earlier entry.
Member
|
In #17327 I added some logic ( |
Member
Author
|
@weswigham done. |
Now that we're smarter about where we declare the extracted local, we can ignore usage problems in the innermost script - it'll always have access to the same symbols as the extracted expression.
RyanCavanaugh
approved these changes
Oct 2, 2017
Using the same description as for functions was confusing because the extracted constant was inserted below the top-level of that scope.
mhegazy
approved these changes
Oct 2, 2017
This was referenced Oct 2, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...mostly by putting them closer to the extraction site.
They now also follow all leading comments in a file (unfortunately, including the doc comment on the first declaration).
Bonus: Special case declaration lists - declare the new variable as part of the list, rather than before it, in case it depends on an earlier entry.