Add alwaysStrict option#16562
Merged
Merged
Conversation
|
@t-mrt, |
Contributor
Author
|
Travis CI build failed. I will correct this shortly. |
Member
|
Can you also add these to the |
Contributor
Author
|
review please. |
Member
|
@weswigham can you look at this? |
Member
|
Are all the whitespace changes required? They are adding a lot of noise. Other than removing that, it looks good. |
weswigham
requested changes
Jun 29, 2017
| changeTracker.insertNodeAfter(sourceFile, findChild("M", sourceFile), createTestClass(), { prefix: newLineCharacter }); | ||
| }); | ||
| } | ||
| { |
Member
There was a problem hiding this comment.
There's still these whitespace changes, too
Contributor
Author
There was a problem hiding this comment.
I removed {} because function declarations cannot be nested inside a statement or block in strict mode. This is not cosmetic change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16531