Skip to content

Allow running in strict mode#16557

Merged
mhegazy merged 1 commit into
microsoft:masterfrom
t-mrt:allow_srtict_mode
Jun 15, 2017
Merged

Allow running in strict mode#16557
mhegazy merged 1 commit into
microsoft:masterfrom
t-mrt:allow_srtict_mode

Conversation

@t-mrt
Copy link
Copy Markdown
Contributor

@t-mrt t-mrt commented Jun 15, 2017

arguments can't be assigned in strict mode.

Fixes #16531

`arguments` can't be assigned in strict mode
@msftclas
Copy link
Copy Markdown

@t-mrt,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@mhegazy mhegazy merged commit 675e7f0 into microsoft:master Jun 15, 2017
@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Jun 15, 2017

thanks @t-mrt. wanna add --alwaysStrict to the build script to avoid this happening again?

@t-mrt
Copy link
Copy Markdown
Contributor Author

t-mrt commented Jun 15, 2017

@mhegazy Thank you for your trouble. I made PR. #16562

mhegazy pushed a commit that referenced this pull request Jun 15, 2017
`arguments` can't be assigned in strict mode
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants